Skip to content

Fixes typing - IMPORTANT this is not a translation change, this is an internal change of the value field for the translations - ANOTHER IMPORTANT: This has to be changed in all language translation files as well #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benediktjohannes wants to merge 4 commits into from
Closed

Fixes typing - IMPORTANT this is not a translation change, this is an internal change of the value field for the translations - ANOTHER IMPORTANT: This has to be changed in all language translation files as well #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae16db1
Update EditAddressScreen.kt
benediktjohannes Jan 14, 2026
c80f62c
Update WasmCode.h
benediktjohannes Jan 14, 2026
0c240c6
Update DeleteAddressDialog.kt
benediktjohannes Jan 14, 2026
ad0fa80
Update strings.xml
benediktjohannes Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/src/wasm/WasmCode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ class CodeSegment : public ShareableBase<CodeSegment> {
// will always be aligned to the executable code alignment.
//
// Random padding is added before the code range when we are aligning to the
// system page size, the start addressess of all the code memories will not
// system page size, the start addresses of all the code memories will not
// conflict in associative icaches.
//
// Here's a picture that illustrates the resulting structure of allocations:
Expand Down
6 changes: 3 additions & 3 deletions ...fenix/app/src/main/java/org/mozilla/fenix/settings/address/ui/edit/DeleteAddressDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,21 +39,21 @@ internal fun DeleteAddressDialog(store: AddressStore) {
AlertDialog(
text = {
Text(
text = stringResource(R.string.addressess_confirm_dialog_message_2),
text = stringResource(R.string.addresses_confirm_dialog_message_2),
style = FirefoxTheme.typography.body2,
)
},
onDismissRequest = { store.dispatch(DeleteDialogAction.CancelTapped) },
confirmButton = {
TextButton(
text = stringResource(R.string.addressess_confirm_dialog_ok_button),
text = stringResource(R.string.addresses_confirm_dialog_ok_button),
onClick = { store.dispatch(DeleteDialogAction.DeleteTapped) },
modifier = Modifier.testTag(EditAddressTestTag.DIALOG_DELETE_BUTTON),
)
},
dismissButton = {
TextButton(
text = stringResource(R.string.addressess_confirm_dialog_cancel_button),
text = stringResource(R.string.addresses_confirm_dialog_cancel_button),
onClick = { store.dispatch(DeleteDialogAction.CancelTapped) },
modifier = Modifier.testTag(EditAddressTestTag.DIALOG_CANCEL_BUTTON),
)
Expand Down
2 changes: 1 addition & 1 deletion ...d/fenix/app/src/main/java/org/mozilla/fenix/settings/address/ui/edit/EditAddressScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ private fun FormButtons(store: AddressStore) {
Row {
if (store.state.isEditing) {
DestructiveButton(
text = stringResource(R.string.addressess_delete_address_button),
text = stringResource(R.string.addresses_delete_address_button),
modifier = Modifier.testTag(EditAddressTestTag.DELETE_BUTTON),
) {
store.dispatch(DeleteTapped)
Expand Down
8 changes: 4 additions & 4 deletions mobile/android/fenix/app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2787,13 +2787,13 @@
<!-- The text for the "Cancel" button for cancelling adding, updating or deleting an address -->
<string name="addresses_cancel_button">Cancel</string>
<!-- The text for the "Delete address" button for deleting an address -->
<string name="addressess_delete_address_button">Delete address</string>
<string name="addresses_delete_address_button">Delete address</string>
<!-- The title for the "Delete address" confirmation dialog -->
<string name="addressess_confirm_dialog_message_2">Delete this address?</string>
<string name="addresses_confirm_dialog_message_2">Delete this address?</string>
<!-- The text for the positive button on "Delete address" dialog -->
<string name="addressess_confirm_dialog_ok_button">Delete</string>
<string name="addresses_confirm_dialog_ok_button">Delete</string>
<!-- The text for the negative button on "Delete address" dialog -->
<string name="addressess_confirm_dialog_cancel_button">Cancel</string>
<string name="addresses_confirm_dialog_cancel_button">Cancel</string>
<!-- The text for the "Save address" menu item for saving an address -->
<string name="address_menu_save_address">Save address</string>
<!-- The text for the "Delete address" menu item for deleting an address -->
Expand Down