Bug 2036474 - Updated s2s telemetry#247
Closed
fmasalha wants to merge 312 commits into
Closed
Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
fmasalha
force-pushed
the
s2s-telemetry-fixes
branch
from
f8eabbc to
be0f7e2
Compare
Contributor
Author
segunfamisa
reviewed
May 8, 2026
| @@ -1,3 +1,2 @@ | |||
| lsan-disabled: true | |||
| leak-threshold: [default:102400, tab:51200] | |||
| prefs: [network.http.happy_eyeballs_enabled:false] | |||
Contributor
There was a problem hiding this comment.
Hm. Is this intentional?
segunfamisa
reviewed
May 8, 2026
|
|
||
| - name: network.http.happy_eyeballs_enabled | ||
| type: RelaxedAtomicBool | ||
| value: @IS_EARLY_BETA_OR_EARLIER@ |
Contributor
There was a problem hiding this comment.
What's this change about? 🤔
fmasalha
force-pushed
the
s2s-telemetry-fixes
branch
from
be0f7e2 to
2745043
Compare
Automatic update from web-platform-tests Make InterestEvent not composed See this issue: whatwg/html#11148 for a discussion of the same issue for the `command` events. For the same reasons, `interest` and `loseinterest` should not be composed. Fixed: 505830923 Change-Id: I29fbc52b5c9d206c06c34a151efe68ac2100aca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7797864 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1621820} -- wpt-commits: e4852925244dc36edf84e66fac06d77b2815a600 wpt-pr: 59519
…bleUntrustedNetwork code, a=testonly Automatic update from web-platform-tests [Fenced Frames] Remove window.fence.disableUntrustedNetwork code This is the 2nd CL in a series that removes fenced storage read(FSR) code. This CL does the following: - removes window.fence.disableUntrustedNetwork API surface and its implementation. 1st CL: https://chromium-review.googlesource.com/c/chromium/src/+/7709973 Follow up CLs will remove fence.notifyEvent Fenced Storage Read's "do not launch" status announcement: https://privacysandbox.google.com/overview/status window.fence.disableUntrustedNetwork is gated behind a default disabled feature flag and it was never enabled, so this CL does not impact any launched behavior. OBSOLETE_HISTOGRAM[Blink.FencedFrame.DisableUntrustedNetworkOutcome]=Feature has been deprecated Also modified NetworkServiceRestartBrowserTest.RestoreNetworkRevocationNonces to work for Connection Allowlists. Bug: 499191497 Change-Id: Ie03a9fd24dda8850ee25bd5407f4961743fefded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7709872 Reviewed-by: Andrew Verge <averge@chromium.org> Reviewed-by: Sophie Chang <sophiechang@chromium.org> Reviewed-by: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Nicolás Peña <npm@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1621983} -- wpt-commits: a3d9841b7f2df6105fbe9739297d38ef89bfa76a wpt-pr: 59521
…ied to embedded content, a=testonly Automatic update from web-platform-tests [SVG] (4) Add flag to block filters applied to embedded content As outlined in: https://lyra.horse/blog/2025/12/svg-clickjacking/ SVG filters applied to frames/plugins contain a risk cross-origin information extraction. This CL uses a ScopedPaintChunkProperties to modify the effects to be applied to the embedded content/object where needed. The flag logic was merged in with the count logic as that was the easiest place to ensure we could control which types of frames were being impacted. This is kept independent of the count logic as we cannot get the same depth of information when painting, and we do not want to prevent local frames from getting filters applied. This CL is part of a series of CLs: (1) UKM filters applied to embedded content (2) UMA filters applied to embedded content (3) Note filter addition or removal across will-change hints (4) Add flag to block filters applied to embedded content Bug: 476646486 Change-Id: I43a601e19e531b0bad9d0730254565e913af8b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7786012 Auto-Submit: Ari Chivukula <arichiv@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1622005} -- wpt-commits: 93dc06fb1d71adab5708d85e0437265af5e0a29e wpt-pr: 59522
wpt-pr: 59522 wpt-type: metadata
…/show_bug.cgi?id=313278, a=testonly Automatic update from web-platform-tests WebKit export of https://bugs.webkit.org/show_bug.cgi?id=313278 (#59507) -- wpt-commits: 2dd9ed8b498d39a49e5d201db562c462786a9c41 wpt-pr: 59507
…and with var() in repeat(), a=testonly Automatic update from web-platform-tests [Masonry] Fix crash in grid-lanes shorthand with var() in repeat() The grid-lanes shorthand parser used manual Save()/Restore() to backtrack when track parsing failed. With var() inside repeat(), the parser consumed the look-ahead token, causing Restore() to hit a DCHECK failure. This fix replaces manual Save()/Restore() with CSSParserSavePoint, which correctly handles stream state restoration. Screenshots: https://imgur.com/a/HjwVv65 Bug: 343257585 Change-Id: Iec7ca2128dd8ca86f7a19c165bc79fb5e5a69efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7793112 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Yanling Wang <yanlingwang@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1620532} -- wpt-commits: 0676f1178459e6fef1afa9b88ddaeacae4545259 wpt-pr: 59464
…tart alignment., a=testonly Automatic update from web-platform-tests [caret-shape] Fix caret-shape with non-start alignment. This bug was found within: https://chromium-review.googlesource.com/c/chromium/src/+/7795908 While making local variables "const". Previously we'd calculate the inline_offset "x" using the variable "caret_width". After calculating "x" we'd then mutate "caret_width" to reflect the correct size with "caret-shape:underscore" or similar set. This resulted in an incorrect inline-offset. To fix, shift the calculation of the caret-size before "x" (and make const). Additionally makes the block-start calculation more readable. Change-Id: Ide54ae56fa0d94aa5a6ac58e528a397f7324396a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7801296 Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1622064} -- wpt-commits: 0f369da7074035f2b7fd27d191231463886a9a7c wpt-pr: 59526
wpt-pr: 59526 wpt-type: metadata
…efinite size containers, a=testonly Automatic update from web-platform-tests [Masonry] Implement fill-reverse for indefinite size containers Implement fill-reverse for the case of alignment in an indefinite stacking axis. The only case where this would happen is in the columns layout with align-content, in which case we would use the intrinsic stacking axis size to help us determine placement. This change also moves the fill-reverse code into `PlaceGridLanesItems` after `RunGridLanesPlacementPhase`, using a new method `ReverseChildrenInDirection`, so that we can have access to the stacking axis size before we perform any reversals. This also helps us to keep the placement code and fill-reverse logic in separate areas for better maintainability. A follow-up change will be needed to handle OOF items in both fill-reverse and regular content alignment in grid-lanes. At the moment, we're attempting to move the static positions of the OOF items before any OOF items have actually been placed. Bug: 343257585 Change-Id: I2ea3504852bae46aaf33748834bf1ece4753e894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7718181 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Yanling Wang <yanlingwang@microsoft.com> Commit-Queue: Celeste Pan <celestepan@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1622111} -- wpt-commits: 15136312c34cc96237fcb158d3b81d150204d327 wpt-pr: 59468
wpt-pr: 59468 wpt-type: metadata
…tion on standalone axis, a=testonly Automatic update from web-platform-tests [Masonry] Add tests for subgrid contribution on standalone axis In CL:5120550, Grid added support for honoring the specified height of a subgrid in its contribution in the standalone axis. We had a TODO in grid lanes for adding similar code handling in item contribution calculations. However, because grid lanes is 1D, we don't have to handle this same code path, because the standalone axis of a subgrid under a grid-lanes container will never contribute to track sizing. Thus, this CL removes this TODO, and adds a couple of tests to ensure this is already behaving as expected in grid lanes. Bug: 343257585 Change-Id: I8ec50c8f0c590ff1905a16a230eb4573749ddfca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7802215 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1622118} -- wpt-commits: ccb92b5a45bacc277fc61020b92bd5f0e9ea2119 wpt-pr: 59529
wpt-pr: 59529 wpt-type: metadata
…lect) for menulist, a=testonly Automatic update from web-platform-tests Use position/sizing CSS from ::picker(select) for menulist - display:flex with flex-direction:column does the same thing as display:block which ::picker(select) uses, so use display:block instead. - ::picker(select) uses position:fixed instead of position:absolute, so use that instead. This doesn't seem to change much. - positioning when there is no invoker should match popovers, so use margin:0 and inset:auto. - When there are too many menuitems to fit in the viewport, the menuitem should create a scrollbar rather than extending the length of the document. max-block-size:stretch and overflow:auto achieve this just like ::picker(select). - ::picker(select) doesn't use border-radius and there isn't a good reason to add one here, so remove the commented out border-radius. Bug: 406566432 Change-Id: Ifde6be60446e97ec4b59450fd698bc6c1174ff3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7801896 Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1622129} -- wpt-commits: bfd80385df09e425680fe4525c2ef849712e9a6d wpt-pr: 59531
wpt-pr: 59531 wpt-type: metadata
…ving shorthands, a=testonly Automatic update from web-platform-tests Propagate attr() taint ranges when resolving shorthands When resolving pending substitutions for shorthand properties, the original text is reparsed into a new CSSParserTokenStream. Previously, the attr() taint ranges from the CSSVariableData were not passed along to the new stream. This allowed values from attr() functions to bypass security checks when used within shorthand properties. This patch ensures that `GetAttrTaintedRanges()` is passed to the new `CSSParserTokenStream` when reparsing the shorthand value, correctly enforcing attr() security restrictions. Fixed: 502035074 Change-Id: I6dff0854f29937988a757ded902b6f6c47802773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7747847 Commit-Queue: Munira Tursunova <moonira@google.com> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1613629} -- wpt-commits: 238898ed9c0848eff30cda889d935153ef299963 wpt-pr: 59261
…nsertion/removal steps, a=testonly Automatic update from web-platform-tests Don't update selectedcontent in option insertion/removal steps Modifying the DOM by updating selectedcontent elements during insertion or removal steps is bad for security reasons. We already removed the selectedcontent element removal steps which was one way this can happen, but the option's InsertedInto and RemovedFrom methods may change which option is selected, which will synchronously update the selectedcontent element. This patch fixes this by moving the selectedcontent updating to the post-insertion steps for insertion, and by using a microtask to update on removal if needed. This matches the behavior in the spec PR: whatwg/html#12263 Bug: 458113204 Change-Id: I42bb94c6eace93445cfbc816529e42ca8a561b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7745871 Reviewed-by: David Baron <dbaron@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1622241} -- wpt-commits: 8116dc1ced751ff3a62c58e020f3d7d0ad61553b wpt-pr: 59528
wpt-pr: 59528 wpt-type: metadata
…/show_bug.cgi?id=302262, a=testonly Automatic update from web-platform-tests WebKit export of https://bugs.webkit.org/show_bug.cgi?id=302262 -- wpt-commits: 0661a068a53a2ff99a0407f92cb202b966bb23c1 wpt-pr: 55993
… a=testonly Automatic update from web-platform-tests Map "Interest invokers" to web-features -- wpt-commits: 87b253339fe8687aaff5cd6f58599550d5b92ea6 wpt-pr: 59219
Automatic update from web-platform-tests Adjust URL of Web NFC (#59143) Spec repository was moved on GitHub from `w3c/web-nfc` to `w3c-cg/web-nfc`. This adjusts the spec URL accordingly (FWIW, former URL redirects to the new one). -- wpt-commits: d6c2c5cd19df12f86f2f5cc259d95f5f3e440f41 wpt-pr: 59143
…ame, a=testonly Automatic update from web-platform-tests [css-borders] Update "corner" property name (#59026) The "corners" shorthand property was renamed to "corner" in August of 2025. w3c/csswg-drafts#11623 w3c/csswg-drafts#12660 w3c/csswg-drafts#12740 -- wpt-commits: 30ff7e450d1ae7e953e17fb0b2d9e68f195be0f3 wpt-pr: 59026
wpt-pr: 59026 wpt-type: metadata
…od, a=testonly Automatic update from web-platform-tests [CE] Update shape of setConstraints method setConstraints now takes a dictionary of MediaTrackConstraintSet as a parameter bug: 507309053 Change-Id: Iff89a4531028c8a219cb2085425897a7f19ba9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7797479 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Ravjit Uppal <ravjit@chromium.org> Reviewed-by: Thomas Nguyen <tungnh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1622376} -- wpt-commits: 6eec4679b96fe0810cf415812330ea6e272aedf2 wpt-pr: 59536
wpt-pr: 59536 wpt-type: metadata
…style-system-reviewers,dshin Enable this property for Servo builds of Stylo (gated behind `layout.unimplemented`), so that Blitz can use it. Imports servo/stylo#356 Differential Revision: https://phabricator.services.mozilla.com/D299354
…eviewers,dshin Imports servo/stylo#357 Differential Revision: https://phabricator.services.mozilla.com/D299355
…system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D299357
…sx1500-aarch64 r=aryx,layout-reviewers,emilio
Move six suites off Intel onto the M4 fleet: jsreftest, reftest,
marionette-integration, marionette-unittest, telemetry-tests-client,
test-verify-wpt. All validated clean on macosx1500-aarch64/{debug,opt}
across two validation pushes after the two fuzzy annotations below.
Reftest fuzzy annotations for Apple Silicon-specific pixel variance:
- layout/reftests/box-shadow/boxshadow-rotated.html: M4 saw 5442
differing pixels (max 13), one above the existing 5250 ceiling.
Add fuzzy-if(appleSilicon,0-13,0-6000).
- layout/reftests/bugs/1415987-1.html: M4 saw 6029 differing pixels
(max 255), four above the existing 6025 ceiling. Existing entry
already has a wider gtkWidget allowance; add a parallel
fuzzy-if(appleSilicon,0-255,0-6500).
Both are software-rendering pixel-rasterization differences across
architectures, not regressions.
Initially included gtest, test-verify, and test-verify-gpu but dropped:
- gtest hits arch-specific failures (PHC.TestPHCAllocations,
Jemalloc.BaseAllocMergeSplit, MediaDataEncoderTest.H264Encode4K*,
VP8VideoTrackEncoder.*, TestUDPSocket.TestUDPSocketMain). The PHC
test has a pending fix on Bug 2021381; the encoder/jemalloc tests
need their own evaluation. Moving gtest separately.
- test-verify (debug+opt) fails in mozharness setup with
ModuleNotFoundError: No module named 'yaml' coming out of
manifestparser/toml.py. PyYAML is missing from the worker Python
env on gecko-t-osx-1500-m4 in the verify-tools path. Doesn't affect
test-verify-wpt, which uses a different mozharness path.
test-verify-gpu likely has the same issue but wasn't scheduled in
the validation push (no GPU test mods); deferring with test-verify.
crashtest is left alone here; it's covered by D294786 (Bug 2032601)
already in flight.
Differential Revision: https://phabricator.services.mozilla.com/D299130
…mkennedy Differential Revision: https://phabricator.services.mozilla.com/D298945
…s,mkennedy,bolsson Differential Revision: https://phabricator.services.mozilla.com/D298946
…ment, enabled on Nightly only, r=dimi,credential-management-reviewers,fluent-reviewers,ai-platform-reviewers,bolsson,vazish Differential Revision: https://phabricator.services.mozilla.com/D297096
…ix the useMLInference getter, r=dimi,credential-management-reviewers Differential Revision: https://phabricator.services.mozilla.com/D298995
…credential-management-reviewers Differential Revision: https://phabricator.services.mozilla.com/D299018
…th in backup manifest for cross-platform recovery. r=search-reviewers,cdupuis,Standard8" as requested by dev. This reverts commit 37b1949.
…window is enabled r=Mardak,mak,rrando,places-reviewers,ai-models-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers ,urlbar-reviewers Differential Revision: https://phabricator.services.mozilla.com/D296244
…wers,bolsson Differential Revision: https://phabricator.services.mozilla.com/D294489
…eeler,geckoview-reviewers,android-reviewers,android-l10n-reviewers,flod,geckoview-api-reviewers,jonalmeida Differential Revision: https://phabricator.services.mozilla.com/D295909
…DONTBUILD Since the implementation of Firefox's Terms of Use, the flipping of the `uploadEnabled` pref is no longer the simple one-stop-shop for disabling data collection. Now it only disables the data collection for pings that don't have `follows_collection_enabled: false` set. Differential Revision: https://phabricator.services.mozilla.com/D299365
… code r=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D298817
This sync htmlparser to the contents of its 69af110 commit (just before changes to select parsing). Differential Revision: https://phabricator.services.mozilla.com/D298818
…=hsivonen Differential Revision: https://phabricator.services.mozilla.com/D298819
…mac-reviewers,spohl Applies the zoom factor to the calculated font size. Fixes the font sizing in menulists within a zoomed document. Note that this does not currently affect the checkmark (bug 2037198); depending on which patch is approved first I will update either this or that patch to also apply zoom for the font size calculation in NativeMenuMac::ShowMenuAnchored. Differential Revision: https://phabricator.services.mozilla.com/D299292
…s. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D298025
… general numeric types. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D298740
…t be resolved at parse time. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D298026
…esolved at parse time. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D298027
…d at parse time. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D298028
…esolved at parse time. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D298029
…ed at parse time. r=firefox-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D298030
…theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,mstriemer,adw,dao Differential Revision: https://phabricator.services.mozilla.com/D297121
…le dialog change r=dpop The UI test was disabled when the download dialog changed. In the meantime the assertions and interactions with the new dialog were refactored. All 9 UI tests successfully passed 10x on Firebase ✅ Differential Revision: https://phabricator.services.mozilla.com/D299349
fmasalha
force-pushed
the
s2s-telemetry-fixes
branch
from
2745043 to
e9396a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.