Bug 2053379 - Fix ShareFragment crash on rapid menu clicks. r=#android-reviewers#318
Closed
toaha63 wants to merge 1 commit into
Closed
Bug 2053379 - Fix ShareFragment crash on rapid menu clicks. r=#android-reviewers#318toaha63 wants to merge 1 commit into
toaha63 wants to merge 1 commit into
Conversation
…d-reviewers The crash occurs when the user clicks the share icon rapidly. The root cause is a race condition in `MenuNavigationMiddleware.kt`. **Problem:** In the `MenuAction.Navigate.Share` block, `onDismiss()` is called asynchronously after `shareUseCases.shareUrl()`. This can interfere with the back stack when the share button is clicked multiple times in quick succession, leading to an `IllegalStateException`. **Solution:** Replace `onDismiss()` with a synchronous and safe navigation call: `navController.popBackStack(R.id.menuDialogFragment, true)`. This ensures the menu dialog is removed from the back stack immediately and *before* navigating to the ShareFragment, eliminating the race condition. **Tested:** - Verified locally that rapid clicking no longer causes a crash. - Confirmed that the share functionality works as expected in both normal and private browsing modes. Signed-off-by: Hasin Israk Toaha <128958545+toaha63@users.noreply.github.com>
No Taskcluster jobs started for this pull requestThe |
Contributor
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crash occurs when the user clicks the share icon rapidly. The root cause is a race condition in
MenuNavigationMiddleware.kt.Problem:
In the
MenuAction.Navigate.Shareblock,onDismiss()is called asynchronously aftershareUseCases.shareUrl(). This can interfere with the back stack when the share button is clicked multiple times in quick succession, leading to anIllegalStateException.Solution:
Replace
onDismiss()with a synchronous and safe navigation call:navController.popBackStack(R.id.menuDialogFragment, true).This ensures the menu dialog is removed from the back stack immediately and before navigating to the ShareFragment, eliminating the race condition.
Tested: