Bug 2021407 - Adds shared prefs implementation of summarization settings#98
Closed
boek wants to merge 1 commit into
Closed
Bug 2021407 - Adds shared prefs implementation of summarization settings#98boek wants to merge 1 commit into
boek wants to merge 1 commit into
Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
Contributor
Author
segunfamisa
approved these changes
Mar 5, 2026
| } | ||
|
|
||
| /** | ||
| * Creates am implementation of [SummarizationSettings] that is backed by [SharedPreferences]. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Creates am implementation of [SummarizationSettings] that is backed by [SharedPreferences]. | |
| * Creates an implementation of [SummarizationSettings] that is backed by [SharedPreferences]. |
| internal class SharedPrefsBackedSummarizationSettings( | ||
| private val prefs: SharedPreferences, | ||
| ) : SummarizationSettings { | ||
| override suspend fun getHasConsentedToShake(): Boolean { |
Contributor
There was a problem hiding this comment.
I wonder if we can remove the "get" and make it less verbose
| fun sharedPrefs( | ||
| context: Context, | ||
| ): SummarizationSettings { | ||
| val prefs = context.getSharedPreferences("summarization_prefs", MODE_PRIVATE) |
Contributor
There was a problem hiding this comment.
I like (lowkey prefer) this, but i got the feeling that we wanted to stick to putting prefs in settings.kt and then have our settings backed version.
Contributor
Author
There was a problem hiding this comment.
I agree, I'm going to land this for now and we can revisit next week as we wire everything else up.
boek
force-pushed
the
bug_2021407_shared_prefs_s2s_settings
branch
from
ad2d5f7 to
2f9a4fd
Compare
|
Pull request closed by commit 0bbf19a |
lando-worker Bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
…ngs r=segunfamisa [try](https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=1837750) Pull request: #98
akliuxingyuan
pushed a commit
to akliuxingyuan/android-components
that referenced
this pull request
Apr 23, 2026
…ngs r=segunfamisa [try](https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=1837750) Pull request: mozilla-firefox/firefox#98
akliuxingyuan
pushed a commit
to fork-maintainers/iceraven-browser
that referenced
this pull request
Apr 23, 2026
…ngs r=segunfamisa [try](https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=1837750) Pull request: mozilla-firefox/firefox#98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try