Use red trash icon and fix deleted string (#1146)

* Use red trash icon and fix deleted string

* Reformat toast

Author: Elise Richards

app/src/main/java/mozilla/lockbox/action/ToastNotificationAction.kt

@@ -37,7 +37,7 @@ sealed class ToastNotificationAction(
     data class ShowDeleteToast(val entryName: String?) : ToastNotificationAction(
         ToastNotificationViewModel(
             R.string.entry_deleted_toast,
-            R.drawable.ic_check,
+            R.drawable.ic_delete_red,
             entryName
         )
     )

app/src/main/java/mozilla/lockbox/presenter/RoutePresenter.kt

@@ -122,7 +122,7 @@ abstract class RoutePresenter(
         val layoutInflater = LayoutInflater.from(activity)
 
         toast.view = layoutInflater.inflate(R.layout.toast_view, container, false)
-        toast.setGravity(Gravity.FILL_HORIZONTAL or Gravity.BOTTOM, 0, 0)
+        toast.setGravity(Gravity.FILL_HORIZONTAL or Gravity.BOTTOM, 0, 216)
 
         val view = toast.view.findViewById(R.id.message) as TextView
         val message = action.viewModel.message

app/src/main/res/drawable-hdpi/ic_delete_red.png

@@ -1,28 +1,44 @@
 <?xml version="1.0" encoding="utf-8"?>
-<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:background="@android:color/transparent">
+
+<androidx.constraintlayout.widget.ConstraintLayout
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:layout_marginBottom="87dp"
+    android:background="@android:color/transparent" >
 
     <LinearLayout
             android:layout_width="match_parent"
             android:layout_height="48dp"
             android:layout_margin="10dp"
+            android:layout_marginBottom="87dp"
             android:background="@drawable/rounded_corner_bg"
             android:elevation="2dp"
-            android:gravity="center_vertical">
+            android:gravity="center_vertical"
+            app:layout_constraintTop_toTopOf="parent"
+            >
 
         <ImageView
                 android:id="@+id/icon"
-                android:src="@drawable/ic_check"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_marginStart="16sp"
-                android:contentDescription="@string/toast_icon_description" />
+                android:contentDescription="@string/toast_icon_description"
+                android:src="@drawable/ic_check"
+                app:layout_constraintBottom_toBottomOf="parent"
+                app:layout_constraintStart_toStartOf="parent"
+                app:layout_constraintTop_toTopOf="parent" />
+
         <TextView
                 android:id="@+id/message"
                 style="@style/ToastTextAppearance"
                 android:layout_width="match_parent"
-                android:layout_height="wrap_content" />
+                android:layout_height="wrap_content"
+                android:layout_marginStart="8sp"
+                app:layout_constraintBottom_toBottomOf="parent"
+                app:layout_constraintEnd_toEndOf="parent"
+                app:layout_constraintStart_toEndOf="@id/icon"
+                app:layout_constraintTop_toTopOf="parent" />
     </LinearLayout>
-</LinearLayout>
+</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/drawable-mdpi/ic_delete_red.png

@@ -313,6 +313,6 @@
     <string name="toast_icon_description">The icon that appears on a toast notification.</string>
 
     <!-- This is the toast message that appears when an entry has been successfully deleted.  -->
-    <string name="entry_deleted_toast">%1$s deleted.</string>
+    <string name="entry_deleted_toast">%1$s deleted</string>
 
 </resources>