Skip to content

Commit 04acfca

Browse files
Bugfix FXIOS-15317 [Translations Phase 2] Settings sections display incorrect colors in Private Browsing (#32984)
Use layer5 instead of layer2 for translation settings cell backgrounds. In the private theme, layer2 equals layer1 (both Violet90), making cells indistinguishable from the background. layer5 (Ink20) matches the color used by other settings cells (ThemedTableViewCell) and provides the correct visual separation in private browsing.
1 parent 5079bf8 commit 04acfca

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

firefox-ios/Client/Frontend/Settings/Translation/TranslationAddLanguageCell.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ final class TranslationAddLanguageCell: UICollectionViewListCell, ThemeApplicabl
2020
content.textProperties.color = theme.colors.actionPrimary
2121
contentConfiguration = content
2222
backgroundConfiguration = .listGroupedCell()
23-
backgroundConfiguration?.backgroundColor = theme.colors.layer2
23+
backgroundConfiguration?.backgroundColor = theme.colors.layer5
2424
}
2525
}

firefox-ios/Client/Frontend/Settings/Translation/TranslationLanguageCell.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ final class TranslationLanguageCell: UICollectionViewListCell, ThemeApplicable {
2424
content.secondaryTextProperties.color = theme.colors.textSecondary
2525
contentConfiguration = content
2626
backgroundConfiguration = .listGroupedCell()
27-
backgroundConfiguration?.backgroundColor = theme.colors.layer2
27+
backgroundConfiguration?.backgroundColor = theme.colors.layer5
2828
}
2929
}

firefox-ios/Client/Frontend/Settings/Translation/TranslationPickerLanguageCell.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ final class TranslationPickerLanguageCell: UITableViewCell {
2020
content.textProperties.color = theme.colors.textPrimary
2121
content.secondaryTextProperties.color = theme.colors.textSecondary
2222
contentConfiguration = content
23-
backgroundColor = theme.colors.layer2
23+
backgroundColor = theme.colors.layer5
2424
}
2525
}

firefox-ios/Client/Frontend/Settings/Translation/TranslationToggleCell.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ final class TranslationToggleCell: UICollectionViewListCell, ThemeApplicable {
2525
contentConfiguration = content
2626
toggle.onTintColor = theme.colors.actionPrimary
2727
backgroundConfiguration = .listGroupedCell()
28-
backgroundConfiguration?.backgroundColor = theme.colors.layer2
28+
backgroundConfiguration?.backgroundColor = theme.colors.layer5
2929
}
3030
}

0 commit comments

Comments
 (0)