Search results is dismissed after user rotates to landscape and back to portrait

[data-sync-user]

While testing https://github.com/mozilla-mobile/firefox-ios/pull/33913 fix I found this bug following the steps from https://mozilla-hub.atlassian.net/browse/FXIOS-15837 the search results screen is dismissed

Steps to reproduce

1. Open Firefox.
2. Tap on the searchbar and type something.
3. Turn the device in landscape then back to portrait.
4. Observe the search results.

Expected result

Search results is visible

Actual result

When changing back to portrait, search results is dismissed and homepage is visible instead.
Note keyboard is still visible if the user continues typing the search results is shown again

 

Device & Build Information

• Devices: iPhone 17 pro (26.3)
• Build: Main, not reproducible in latest Nightly 72113 or 151.1 (71989) but Firefox Suggest is not visible might be related

┆Issue is synchronized with this Jira Task

[data-sync-user]

Yoana Rios Diaz commented from Jira:

Reproducible only if Homepage Pinned Header is enabled.

According to my quick investigation, SearchViewController is still in hierarchy but the ContentContainer is push over, so it covers SearchViewController and it looks like the search results are dismissed seems to be related to BrowserViewController.updateContentContainerTopConstraintchanges where the views are bring to the front.

cc: [~accountid:6237a3581c7f6a007047eb38]