Refactor FXIOS-15151 [Native Error Pages] Rename otherErrorPages flag to wrongHostCertificateErrorPage#32611
Merged
Cramsden merged 3 commits intoApr 14, 2026
Conversation
cyndichin
reviewed
Mar 24, 2026
| case nativeErrorPage | ||
| case noInternetConnectionErrorPage | ||
| case otherErrorPages | ||
| case wrongHostCertificateErrorPage |
Contributor
There was a problem hiding this comment.
@ananyashreesharma what do you think about renaming this to badCertDomainErrorPage instead so that we are consistent with the figma file and error message?
Contributor
Author
There was a problem hiding this comment.
Yes sure, that makes sense!
cyndichin
approved these changes
Mar 30, 2026
cyndichin
left a comment
cyndichin
left a comment
Contributor
There was a problem hiding this comment.
thanks for the renaming!
💪 Quality guardian2 tests files modified. You're a champion of test coverage! 🚀 🥇 Perfect PR sizeSmaller PRs are easier to review. Thanks for making life easy for reviewers! ✨ ✅ New file code coverageNo new file detected so code coverage gate wasn't ran. Client.app: Coverage: 39.39
Generated by 🚫 Danger Swift against e4fd914 |
Contributor
|
🚀 PR merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets
GitHub issue: #32610
JIRA: FXIOS-15151
📜 Description
This PR renames the Nimbus / feature-flag surface from
other_error_pages/.otherErrorPagestowrong_host_certificate_error_page/.wrongHostCertificateErrorPageso the name matches the actual behavior (wrong-host / bad certificate native error page)The Feature Flags debug toggle is unchanged in purpose: it still lets you manually enable/disable this flag for testing and it now uses the renamed flag (
.wrongHostCertificateErrorPage).Note: This PR is part of Outreachy.
Implementation details
nativeErrorPageFeature.yamlNimbusFlaggableFeaturecase and wired it inNimbusFeatureFlagLayer(including the Nimbus value property name after codegen).NativeErrorPageFeatureFlagaccessor toisWrongHostCertificateErrorPageEnabledand updated call sitesNativeErrorPageFeature/ assert the flag (BrowserViewControllerTests,NativeErrorPageFeatureFlagTests).📝 Checklist