Bugfix FXIOS-11802 ⁃ [Autofill and Passwords] Saved Address bar in landscape mode displayed black margins by dicarobinho · Pull Request #32667 · mozilla-mobile/firefox-ios

dicarobinho · 2026-03-25T12:32:38Z

📜 Tickets

Jira ticket
Github issue

💡 Description

Added padding where is necessary

🎥 Demos

Simulator Screenshot - iPad Pro 13-inch (M5) - 2026-03-25 at 12 36 48

Simulator Screenshot - iPhone 11 - 2026-03-25 at 11 45 50

Simulator Screenshot - iPhone 17 Pro Max - 2026-03-25 at 11 36 24

Simulator Screenshot - iPhone 17 Pro Max - 2026-03-25 at 11 36 32

Simulator Screenshot - iPhone 11 - 2026-03-25 at 11 46 03

Simulator Screenshot - iPad Pro 13-inch (M5) - 2026-03-25 at 12 36 36

Before	After

Demo

📝 Checklist

I filled in the ticket numbers and a description of my work
I updated the PR name to follow our PR naming guidelines
I ensured unit tests pass and wrote tests for new code
If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
If adding telemetry, I read the data stewardship requirements and will request a data review
If adding or modifying strings, I read the guidelines and will request a string review from l10n
If needed, I updated documentation and added comments to complex code

…ndscape mode displayed black margins

mergify · 2026-03-25T12:33:19Z

This pull request has conflicts when rebasing. Could you fix it @dicarobinho? 🙏

…s_padding # Conflicts: # firefox-ios/Client.xcodeproj/project.pbxproj

mobiletest-ci-bot · 2026-03-25T12:51:26Z

	Messages
📖	Project coverage: 41.37%

💪 Quality guardian

1 tests files modified. You're a champion of test coverage! 🚀

🥇 Perfect PR size

Smaller PRs are easier to review. Thanks for making life easy for reviewers! ✨

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

Client.app: Coverage: 39.61

File	Coverage
AddressListView.swift	0.0%	⚠️
AddressAutofillSettingsView.swift	0.0%	⚠️
StylingViewModifiers.swift	0.0%	⚠️
AddressCellView.swift	0.0%	⚠️

Generated by 🚫 Danger Swift against 7f46e67

thatswinnie

While we now don't have black margins anymore, it's still not great. The background of the address should be extended to the edges of the screen just like for Save and Fill Addresses.

thatswinnie · 2026-03-26T08:22:16Z

    }
 }
+
+struct DeviceOrientation: ViewModifier {


Why are we comparing width and height here to detect if the view is in landscape? Can't we use UIDeviceOrientation for that? This comparisson will probably not work correctly with stage manager on iPad.

Increased cells margins

thatswinnie · 2026-03-30T12:22:13Z

                    Image(StandardImageIdentifiers.Large.location)
                        .renderingMode(.template)
-                        .padding(.leading, 16)
+                        .modifier(ListItemIconPadding(isLandscape: UIDevice.current.orientation.isLandscape,


This is only getting called once when the view is shown. This should be updated when the device rotates.

thatswinnie · 2026-03-30T12:23:36Z

-
-    func makeBody(configuration: Configuration) -> some View {
-        configuration.label
-            .background(configuration.isPressed ? Color(theme.colors.layer1) : Color(theme.colors.layer2))


Why did we get rid of the color change when the cell is tapped?

By keeping that, I can't achieve extended colour for the cells.

@dicarobinho with this fix we lose the cell selection feedback I check the other autofill screen password and credit card and we have the cell selection feedback I agree with @thatswinnie we should find another solution were we could keep this behaviour

…s_padding

Adjusted padding for table header

thatswinnie

The whole cell should change color when selected, not just part of it. Also for the UIKit cells the selected color is different and the selection state only changes for a short time

…s_padding

…wift Co-authored-by: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>

thatswinnie · 2026-04-22T13:01:03Z

-                Image(StandardImageIdentifiers.Large.location)
+                Image(decorative: StandardImageIdentifiers.Large.location)
                    .renderingMode(.template)
                    .accessibilityHidden(true)


Nit: .accessibilityHidden(true) can be removed now that the image is decorative.

…s_padding

dragosb01

LGTM for automation changes

github-actions · 2026-04-23T11:50:20Z

🚀 PR merged to main, targeting version: 150.2

FXIOS-11802 #25742 ⁃ [Autofill and Passwords] Saved Address bar in la…

6251b70

…ndscape mode displayed black margins

dicarobinho requested a review from thatswinnie March 25, 2026 12:32

dicarobinho marked this pull request as ready for review March 25, 2026 12:32

dicarobinho requested a review from a team as a code owner March 25, 2026 12:32

Merge branch 'main' into afarcasanu/fxios_11802_25742_autofill_addres…

ebfb1ee

…s_padding # Conflicts: # firefox-ios/Client.xcodeproj/project.pbxproj

thatswinnie reviewed Mar 26, 2026

View reviewed changes

Quick code refactor

b160cbe

Increased cells margins

dicarobinho requested a review from thatswinnie March 27, 2026 14:44

thatswinnie reviewed Mar 30, 2026

View reviewed changes

dicarobinho requested a review from thatswinnie March 31, 2026 08:08

Alexandru Farcasanu added 2 commits March 31, 2026 11:58

Handle padding when screen is rotated

c184b90

Fixed SwiftLint error

fe082ac

dicarobinho requested a review from yoanarios April 3, 2026 09:40

Alexandru Farcasanu added 2 commits April 9, 2026 10:02

Merge branch 'main' into afarcasanu/fxios_11802_25742_autofill_addres…

18b5ba3

…s_padding

Added cell selection feedback

efd44c3

Adjusted padding for table header

dicarobinho closed this Apr 9, 2026

dicarobinho reopened this Apr 9, 2026

dicarobinho closed this Apr 9, 2026

dicarobinho reopened this Apr 9, 2026

thatswinnie reviewed Apr 16, 2026

View reviewed changes

Alexandru Farcasanu added 2 commits April 20, 2026 16:27

Merge branch 'main' into afarcasanu/fxios_11802_25742_autofill_addres…

2e61655

…s_padding

Applied highlight color when tapping on cell

8a49eec

dicarobinho requested a review from thatswinnie April 21, 2026 13:45

dicarobinho closed this Apr 22, 2026

dicarobinho reopened this Apr 22, 2026

dicarobinho closed this Apr 22, 2026

dicarobinho reopened this Apr 22, 2026

thatswinnie approved these changes Apr 22, 2026

View reviewed changes

Comment thread firefox-ios/Client/Frontend/Autofill/Address/AddressCellView.swift Outdated

Update firefox-ios/Client/Frontend/Autofill/Address/AddressCellView.s…

933d472

…wift Co-authored-by: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>

thatswinnie reviewed Apr 22, 2026

View reviewed changes

Alexandru Farcasanu added 3 commits April 22, 2026 16:26

Removed accessibility for image

7e74831

Merge branch 'main' into afarcasanu/fxios_11802_25742_autofill_addres…

74e0109

…s_padding

Fixed testDeleteAddress test

7f46e67

dicarobinho requested a review from a team as a code owner April 23, 2026 11:07

dicarobinho requested review from AaronMT and dragosb01 April 23, 2026 11:07

dragosb01 approved these changes Apr 23, 2026

View reviewed changes

dicarobinho merged commit a2e7570 into main Apr 23, 2026
9 checks passed

dicarobinho deleted the afarcasanu/fxios_11802_25742_autofill_address_padding branch April 23, 2026 11:50

data-sync-user mentioned this pull request Apr 28, 2026

[Addresses][Regression] Cannot scroll in "Addresses" section when multiple addresses are saved #33465

Closed

Conversation

dicarobinho commented Mar 25, 2026

📜 Tickets

💡 Description

🎥 Demos

📝 Checklist

Uh oh!

mergify Bot commented Mar 25, 2026

Uh oh!

mobiletest-ci-bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💪 Quality guardian

🥇 Perfect PR size

✅ New file code coverage

Client.app: Coverage: 39.61

Uh oh!

thatswinnie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thatswinnie Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thatswinnie Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

thatswinnie Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

dicarobinho Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

yoanarios Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thatswinnie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thatswinnie Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

dragosb01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mobiletest-ci-bot commented Mar 25, 2026 •

edited

Loading