Bugfix FXIOS-15212 #32729 [Translations Phase 2] "Automatically translate pages when available?" prompt is not displayed on supported webpages by razvanlitianu · Pull Request #32784 · mozilla-mobile/firefox-ios

razvanlitianu · 2026-03-30T11:10:36Z

📜 Tickets

💡 Description

After a user manually translates a page for the first time, a prompt appears at the bottom of the browser offering to enable auto-translate for future pages.

Tapping Enable saves the auto-translate preference and dismisses the prompt
Tapping × dismisses without enabling
The prompt is shown only once, guarded by translationAutoTranslatePromptShown pref
Auto-translate is skipped for the page load immediately following a manual restore, preventing re-translation when the user opts out

🎥 Demos

Demo

📝 Checklist

I filled in the ticket numbers and a description of my work
I updated the PR name to follow our PR naming guidelines
I ensured unit tests pass and wrote tests for new code
If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
If adding telemetry, I read the data stewardship requirements and will request a data review
If adding or modifying strings, I read the guidelines and will request a string review from l10n
If needed, I updated documentation and added comments to complex code

mergify · 2026-03-31T17:54:48Z

This pull request has conflicts when rebasing. Could you fix it @razvanlitianu? 🙏

mobiletest-ci-bot · 2026-04-01T12:00:49Z

Warnings

⚠️

❌ New file code coverage

The following new file(s) are below their scaled coverage:

File	Coverage	Required
`firefox-ios/Client/Frontend/Translations/AutoTranslatePromptView.swift`	0.0%	58.8%

Bypass label ignore-code-coverage detected — reporting as warnings only for this PR.

	Messages
📖	Project coverage: 41.12%

✍️ Strings Updated

Detected changes in Shared/Strings.swift.
To keep strings up to standards, please add a member of the firefox-ios-l10n team as reviewer. 🌍

💪 Quality guardian

2 tests files modified. You're a champion of test coverage! 🚀

🧩 Neat Piece

This PR changes 524 lines. It's a substantial update,
but still review-friendly if there’s a clear description. Thanks for keeping things moving! 🚀

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

🦊 BrowserViewController Check

We’re tracking the size of BrowserViewController.swift to keep it healthy.

✨ Change in file size: +40 lines

Client.app: Coverage: 39.37

File	Coverage
TranslationSettingsMiddleware.swift	86.88%	✅
BrowserViewController.swift	34.83%	⚠️
TranslationsMiddleware.swift	96.36%	✅
BrowserViewControllerState.swift	50.81%	✅
AutoTranslatePromptState.swift	100.0%	✅
TranslationsAction.swift	100.0%	✅
AutoTranslatePromptView.swift	0.0%	⚠️

Shared: Coverage: 61.51

File	Coverage
Prefs.swift	83.7%	✅

Generated by 🚫 Danger Swift against 2046a74

FilippoZazzeroni · 2026-04-02T07:13:10Z

+
+    private func handleAutoTranslatePrompt(state: BrowserViewControllerState) {
+        if state.autoTranslatePromptState.showPrompt {
+            guard autoTranslatePrompt == nil else { return }


nit: we could move this guard up

Moved the guard into showAutoTranslatePrompt() directly.

FilippoZazzeroni · 2026-04-02T07:14:17Z

+
+        if isBottomSearchBar {
+            overKeyboardContainer.addArrangedViewToTop(prompt, animated: false, completion: {
+                self.view.layoutIfNeeded()


do we need to layout the entire view here ? shouldn't the stack view handles it already ?

Removed, the stack view handles this.

FilippoZazzeroni · 2026-04-02T07:14:23Z

+            })
+        } else {
+            bottomContainer.addArrangedViewToTop(prompt, animated: false, completion: {
+                self.view.layoutIfNeeded()


FilippoZazzeroni · 2026-04-02T07:18:40Z

+        switch notification.name {
+        case UIContentSizeCategory.didChangeNotification:
+            ensureMainThread {
+                self.messageLabel.font = FXFontStyles.Regular.body.scaledFont()


instead of having this method here setting up the font when size category changes, we could just specify in the setup of the labels the property adjustFontForContentSizeCategory to true

Both labels already had this set at init, so removed the notification observer entirely.

FilippoZazzeroni · 2026-04-02T07:20:50Z

+
+        public struct AutoTranslatePrompt {
+            public static let Message = MZLocalizedString(
+                key: "", // Translations.AutoTranslatePrompt.Message.v151


why the keys are empty, you don't want to export already the translations ?

Filled in the keys now. I was planning a later PR to enable all but let's do it here also.

mergify · 2026-04-02T08:43:15Z

This pull request has conflicts when rebasing. Could you fix it @razvanlitianu? 🙏

FilippoZazzeroni

Hi @razvanlitianu just added another couple of comments worth checking before merging the rest looks good to me. i'd wait also for @lmarceau 's input before merging

FilippoZazzeroni · 2026-04-02T08:44:31Z

-            guard autoTranslatePrompt == nil else { return }
            showAutoTranslatePrompt()
        } else {
            guard autoTranslatePrompt != nil else { return }


nit: at this point we can remove this since it is already handled in removeAutoTranslatePrompt

I agree, that is redundant.

FilippoZazzeroni · 2026-04-02T08:47:57Z

do you think we need to update the constraints here ? same in removeAutoTranslatePrompt. theoretically the views should auto resize according to the subviews. Could you check this before merging ?

The updateViewConstraints() calls match the microsurvey prompt pattern exactly (lines 2120 and 2144 in BVC). I took the microsurvey as the established reference for this kind of bottom-bar prompt, and kept the same pattern here.

Could you try removing it to see if does something cause it seems redundant to me, and also it is quite expansive to update all the constraints to just remove a view

Tested it, the stack view handles the layout correctly without the explicit constraint update, so removed both calls.

razvanlitianu · 2026-04-02T09:46:23Z

Thanks for the input, @FilippoZazzeroni! I've addressed all the comments and will now wait for @lmarceau's feedback.

razvanlitianu · 2026-04-03T05:41:42Z

@mergify rebase

mergify · 2026-04-03T05:41:55Z

rebase

❌ Base branch update has failed

Details

rebase conflict between base and head

razvanlitianu · 2026-04-03T06:00:28Z

Adding ignore-code-coverage because the added controller AutoTranslatePromptView.swift would benefit more of UItests rather then Unit tests. cc @mozilla-mobile/fxios-unit-test-owners

- Add `translationAutoTranslate` pref key - Add `toggleAutoTranslate` action type and `isAutoTranslateEnabled` middleware payload - Add `isAutoTranslateEnabled` to state and reducer - Add `autoTranslate` section/item to DiffableDataSource - Add auto-translate toggle cell in TranslationPickerSettingsViewController - Add strings: AutoTranslate.Title, AutoTranslate.Footer

- Move auto-translate section below preferred languages - Add initialize action to read isTranslationsEnabled and isAutoTranslateEnabled synchronously before async fetch, preventing toggles from briefly showing incorrect state on load

…ranslation Shows a one-time persistent prompt above the address bar after the user's first manual translation (picker flag only), asking if they want to enable auto-translate. Tapping Enable writes the pref and dismisses; tapping X dismisses without enabling. Prompt is never shown again once seen, and is suppressed if auto-translate is already on. Also fixes a side effect where tapping the active translate icon to restore the original page would immediately re-translate due to auto-translate being enabled — the restore reload is now skipped for that one cycle.

…prompt

@mainactor

- Add accessibilityIdentifier to messageLabel and explicit accessibilityLabel/identifier to enableButton - Remove Notifiable conformance; adjustsFontForContentSizeCategory already handles Dynamic Type - Move guard into showAutoTranslatePrompt(); remove layoutIfNeeded from completion closures - Move @mainactor to class level in AutoTranslatePromptStateTests - Add three tests for maybeShowAutoTranslatePrompt in TranslationsMiddlewareTests - Fill in l10n string keys for AutoTranslatePrompt.Message and EnableButton

…pt show/hide

github-actions · 2026-04-07T17:46:58Z

🚀 PR merged to main, targeting version: 150.0

razvanlitianu changed the title ~~Rlitianu/translations auto translate prompt~~ Bugfix FXIOS-15212 #32729 [Translations Phase 2] "Automatically translate pages when available?" prompt is not displayed on supported webpages Mar 30, 2026

razvanlitianu force-pushed the rlitianu/translations-auto-translate-prompt branch from f5b8764 to 54b7bee Compare April 1, 2026 07:59

razvanlitianu requested review from FilippoZazzeroni, ih-codes and lmarceau and removed request for ih-codes April 1, 2026 11:34

razvanlitianu marked this pull request as ready for review April 1, 2026 11:35

razvanlitianu requested a review from a team as a code owner April 1, 2026 11:35

lmarceau reviewed Apr 1, 2026

View reviewed changes

Comment thread firefox-ios/Client/Frontend/Translations/AutoTranslatePromptView.swift

lmarceau reviewed Apr 1, 2026

View reviewed changes

Comment thread firefox-ios/Client/Frontend/Translations/AutoTranslatePromptView.swift

Comment thread firefox-ios/Client/Frontend/Translations/TranslationsMiddleware.swift

Comment thread ...os/firefox-ios-tests/Tests/ClientTests/TranslationsTests/AutoTranslatePromptStateTests.swift Outdated

FilippoZazzeroni reviewed Apr 2, 2026

View reviewed changes

razvanlitianu requested review from FilippoZazzeroni, flodolo and lmarceau April 2, 2026 08:42

FilippoZazzeroni approved these changes Apr 2, 2026

View reviewed changes

flodolo approved these changes Apr 2, 2026

View reviewed changes

lmarceau approved these changes Apr 2, 2026

View reviewed changes

razvanlitianu added the ignore-code-coverage Use this label with a comment and tag the unit tests owners label Apr 3, 2026

razvanlitianu added 5 commits April 7, 2026 20:15

Fix auto-translate toggle state and section order

02ce8b1

- Move auto-translate section below preferred languages - Add initialize action to read isTranslationsEnabled and isAutoTranslateEnabled synchronously before async fetch, preventing toggles from briefly showing incorrect state on load

Add FXIOS-15025 unit tests for auto-translate toggle

ba35292

Fix SwiftLint violations

9ae4cc8

razvanlitianu added 7 commits April 7, 2026 20:17

Remove unnecessary auto-translate tests

87c3628

Add FXIOS-15025 unit tests for AutoTranslatePromptState

ad04f5d

Fix test_didSelectTargetLanguage_dispatchAction after auto-translate …

80cea27

…prompt

Remove unnecessary await from AutoTranslatePromptStateTests setUp

2d3bb97

Remove redundant guard in handleAutoTranslatePrompt

d8e0d06

Remove redundant updateViewConstraints calls from auto-translate prom…

2046a74

…pt show/hide

razvanlitianu force-pushed the rlitianu/translations-auto-translate-prompt branch from f22fb65 to 2046a74 Compare April 7, 2026 17:18

razvanlitianu merged commit 6c2e810 into main Apr 7, 2026
11 checks passed

razvanlitianu deleted the rlitianu/translations-auto-translate-prompt branch April 7, 2026 17:46

Conversation

razvanlitianu commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Tickets

💡 Description

🎥 Demos

📝 Checklist

Uh oh!

mergify Bot commented Mar 31, 2026

Uh oh!

mobiletest-ci-bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ New file code coverage

✍️ Strings Updated

💪 Quality guardian

🧩 Neat Piece

💬 Description craftsman

🦊 BrowserViewController Check

Client.app: Coverage: 39.37

Shared: Coverage: 61.51

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Apr 2, 2026

Uh oh!

FilippoZazzeroni left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

razvanlitianu commented Apr 2, 2026

Uh oh!

razvanlitianu commented Apr 3, 2026

Uh oh!

mergify Bot commented Apr 3, 2026

❌ Base branch update has failed

Uh oh!

razvanlitianu commented Apr 3, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

razvanlitianu commented Mar 30, 2026 •

edited

Loading

mobiletest-ci-bot commented Apr 1, 2026 •

edited

Loading