Bugfix FXIOS-15055 Link share prompt is displaced on iPad#32875
Conversation
🧹 Tidy commitJust 1 file(s) touched. Thanks for keeping it clean and review-friendly! 🙌 Friday high-fiveThanks for pushing us across the finish line this week! 🙌 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 ✅ New file code coverageNo new file detected so code coverage gate wasn't ran. Client.app: Coverage: 39.31
Generated by 🚫 Danger Swift against 53ebc8e |
|
I have a video. I think the issue is reproducible only when the last tab is partially visible. I don't want to block the merge but would you mind @rilury to investigate Simulator.Screen.Recording.-.iPhone.17.-.2026-04-02.at.16.16.09.mov |
|
Hey, @yoanarios , I investigated and it was impacting the sheet presentation on iPhone for this edge case when the last row was partially visible, as in the attached video. So I updated the code to apply the fix only for iPad, as you suggested. Now, after this change, it is displayed properly also in the case we discussed. I am waiting for you confirmation that the update of the PR is ok and after that I will proceed with the merge. Thank you so much for your attention! |
Thank you @rilury for updating, changes look good please feel free to merge |
|
🚀 PR merged to |

📜 Tickets
Jira ticket
Github issue
💡 Description
This PR solves the issue with the popover for share link that previously did not fit completely on the screen. This bug was happening on history links, bookmarks and reading list on iPad and now this fix solves all the cases and the prompt is displayed corectly.
📝 Checklist