Skip to content

Bugfix FXIOS-15055 Link share prompt is displaced on iPad#32875

Merged
rilury merged 6 commits into
mainfrom
riordan/FXIOS-15055_Link-Share-prompt-is-displaced-on-iPad
Apr 7, 2026
Merged

Bugfix FXIOS-15055 Link share prompt is displaced on iPad#32875
rilury merged 6 commits into
mainfrom
riordan/FXIOS-15055_Link-Share-prompt-is-displaced-on-iPad

Conversation

@rilury
Copy link
Copy Markdown
Collaborator

@rilury rilury commented Apr 2, 2026

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR solves the issue with the popover for share link that previously did not fit completely on the screen. This bug was happening on history links, bookmarks and reading list on iPad and now this fix solves all the cases and the prompt is displayed corectly.

Simulator Screenshot - iPad (A16) - 2026-04-02 at 11 07 35

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@rilury rilury changed the title BUugfix xios 15055 link share prompt is displaced on i pad Bugfix FXIOS-15055 Link share prompt is displaced on iPad Apr 2, 2026
@mobiletest-ci-bot
Copy link
Copy Markdown

mobiletest-ci-bot commented Apr 2, 2026

Messages
📖 Project coverage: 41.0%

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

🙌 Friday high-five

Thanks for pushing us across the finish line this week! 🙌

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

Client.app: Coverage: 39.31

File Coverage
LibraryCoordinator.swift 70.22%

Generated by 🚫 Danger Swift against 53ebc8e

@rilury rilury requested review from thatswinnie and yoanarios April 2, 2026 08:38
@rilury rilury marked this pull request as ready for review April 2, 2026 08:38
@rilury rilury requested a review from a team as a code owner April 2, 2026 08:38
Copy link
Copy Markdown
Contributor

@yoanarios yoanarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean fix, LGTM. I found a small issue on iPhone I don't think is a deal breaker and doesn't reproduce consistently but if you select from the bottom of the list sometimes the Share sheet is not presented from the bottom we could check device type to apply this parameter only for iPad

Image

@yoanarios
Copy link
Copy Markdown
Contributor

I have a video. I think the issue is reproducible only when the last tab is partially visible. I don't want to block the merge but would you mind @rilury to investigate

Simulator.Screen.Recording.-.iPhone.17.-.2026-04-02.at.16.16.09.mov

@rilury
Copy link
Copy Markdown
Collaborator Author

rilury commented Apr 3, 2026

Hey, @yoanarios , I investigated and it was impacting the sheet presentation on iPhone for this edge case when the last row was partially visible, as in the attached video. So I updated the code to apply the fix only for iPad, as you suggested. Now, after this change, it is displayed properly also in the case we discussed. I am waiting for you confirmation that the update of the PR is ok and after that I will proceed with the merge. Thank you so much for your attention!

@yoanarios
Copy link
Copy Markdown
Contributor

Hey, @yoanarios , I investigated and it was impacting the sheet presentation on iPhone for this edge case when the last row was partially visible, as in the attached video. So I updated the code to apply the fix only for iPad, as you suggested. Now, after this change, it is displayed properly also in the case we discussed. I am waiting for you confirmation that the update of the PR is ok and after that I will proceed with the merge. Thank you so much for your attention!

Thank you @rilury for updating, changes look good please feel free to merge

@rilury rilury merged commit 219d07a into main Apr 7, 2026
9 checks passed
@rilury rilury deleted the riordan/FXIOS-15055_Link-Share-prompt-is-displaced-on-iPad branch April 7, 2026 20:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

🚀 PR merged to main, targeting version: 150.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants