Update FXIOS-15319 Move bootstrap to archived-scripts and update READMEs#32894
Update FXIOS-15319 Move bootstrap to archived-scripts and update READMEs#32894adudenamedruby wants to merge 1 commit into
Conversation
|
Still working on this. I have to replace all the bootstrap stuff first in GH jobs too lolololo |
🧹 Tidy commitJust 4 file(s) touched. Thanks for keeping it clean and review-friendly! 🌟 Documentation starGreat documentation touches. Future you says thank you! 📚 ✅ New file code coverageNo new file detected so code coverage gate wasn't ran. Generated by 🚫 Danger Swift against c22196c |
|
|
||
| For information on how to contribute to this project, including communication channels, coding style, PR naming guidelines and more, visit the [Contribution guidelines](https://github.com/mozilla-mobile/firefox-ios/blob/main/CONTRIBUTING.md). | ||
|
|
||
| ## Building the code |
There was a problem hiding this comment.
Shouldn't we provide some guidance for contributors to know how to build the code? At least pointing to fxios?
Also some steps should stay IMO even with fxios:
1. Open the `Client.xcodeproj` under the `firefox-ios` folder in Xcode.
1. Make sure to select the `Fennec` [scheme](https://developer.apple.com/documentation/xcode/build-system?changes=_2) in Xcode.
1. Select the destination device you want to build on.
1. Run the app with `Cmd + R` or by pressing the `build and run` button.
⚠️ Important: In case you have dependencies issues with SPM, please try the following:
- Xcode -> File -> Packages -> Reset Package Caches
There was a problem hiding this comment.
These steps all exist in the main readme for fxios
There was a problem hiding this comment.
But if I am a contributor, how do I know I need to use fxios ?
There was a problem hiding this comment.
That information already exist in the main README :)
| ```shell | ||
| ./bootstrap.sh focus | ||
| ``` | ||
| 1. Open `Blockzilla.xcodeproj` under the `focus-ios` folder in Xcode. |
There was a problem hiding this comment.
These steps all exist in the main readme for fxios
|
This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions! |
📜 Tickets
Jira ticket
Github issue
💡 Description
Title.
📝 Checklist