Skip to content

Refactor FXIOS-15328 [Relay] Refactors & clean-up#32905

Open
mattreaganmozilla wants to merge 3 commits intomozilla-mobile:mainfrom
mattreaganmozilla:mr/15328
Open

Refactor FXIOS-15328 [Relay] Refactors & clean-up#32905
mattreaganmozilla wants to merge 3 commits intomozilla-mobile:mainfrom
mattreaganmozilla:mr/15328

Conversation

@mattreaganmozilla
Copy link
Copy Markdown
Collaborator

📜 Tickets

Jira ticket

💡 Description

Clean-up to RelayController, making some general improvements for readability and smaller function sizes etc.

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@mobiletest-ci-bot
Copy link
Copy Markdown

Messages
📖 Project coverage: 40.94%

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

🧑‍💻 New Task {} detected

New Task {} added in file firefox-ios/Client/Frontend/Browser/RelayController.swift at line 375.
Please add a concurrency reviewer on your PR: @Cramsden @ih-codes @lmarceau

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

Client.app: Coverage: 39.3

File Coverage
RelayController.swift 65.01%

Generated by 🚫 Danger Swift against c4f2271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants