Bugfix FXIOS-15741 [Toolbar] Bugzilla 2036577

[thatswinnie]

📜 Tickets

Jira ticket

💡 Description

Bugzilla 2036577

📝 Checklist

• I filled in the ticket numbers and a description of my work
• I updated the PR name to follow our PR naming guidelines
• I ensured unit tests pass and wrote tests for new code
• If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
• If adding telemetry, I read the data stewardship requirements and will request a data review
• If adding or modifying strings, I read the guidelines and will request a string review from l10n
• If needed, I updated documentation and added comments to complex code

[cyndichin]

Hey @thatswinnie, I wrote the tests that failed testNormalizedHostWithLRIHandlesRTLDomainAppropriately. Taking a look now.

[mattreaganmozilla]

Lgtm

[mattreaganmozilla]

Looks like there's some further discussion happening so I'll re-review after that (thanks @cyndichin for the detailed notes in the Slack thread)

[mattreaganmozilla]

I wrote the tests that failed testNormalizedHostWithLRIHandlesRTLDomainAppropriately. Taking a look now.

@cyndichin Just pinging to make sure this hadn't gotten lost in the shuffle, were there any further updates for this PR?

[cyndichin]

I wrote the tests that failed testNormalizedHostWithLRIHandlesRTLDomainAppropriately. Taking a look now.

@cyndichin Just pinging to make sure this hadn't gotten lost in the shuffle, were there any further updates for this PR?

I merged in my fix for 151.1 and it is QA verified. Discussed with Winnie that we would need to revisit the fix here. However, it may take some time to investigate the path forward. The slack thread will have the most up-date comms.