Bugfix FXIOS-15822 [Unit Test] fix top sites#33844
Closed
cyndichin wants to merge 1 commit into
Closed
Conversation
🧹 Tidy commitJust 1 file(s) touched. Thanks for keeping it clean and review-friendly! 🙌 Friday high-fiveThanks for pushing us across the finish line this week! 🙌 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 ✅ New file code coverageNo new file detected so code coverage gate wasn't ran. ✅ Existing file code coverageNo modified file had significant enough changes for the coverage gate to run. Client.app: Coverage: 41.31
Generated by 🚫 Danger Swift against 9addfdb |
Contributor
Author
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
cyndichin
force-pushed
the
cc/FXIOS-15822_flaky-top-sites
branch
from
5eae242 to
9addfdb
Compare
Contributor
|
This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions! |
github-actions
Bot
added
the
stale
piyyy314
reviewed
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
We started seeing new failures related to our
TopSitesHelperTests:testGetTopSites_removesDuplicatesandtestGetTopSites_withError_completesWithZeroSitesPulling the crash logs from the artifacts, the stack trace looks very similar to the issue faced in this PR: https://github.com/mozilla-mobile/firefox-ios/pull/33619/changes
The test is crashing due to a dependency injection failure when trying to resolve the
FeatureFlagsProvider. The crash occurs during test teardown whenTopSitesProviderImplementationtries to access feature flags.While I cannot reproduce the issue, I think this may be the proper fix and we can monitor. The more issues, the more I feel that we should be injecting these dependencies instead of resolving it through the protocol.
Bitrise:
📝 Checklist