Bugfix FXIOS-15832 ⁃ [Firefox suggest] - Visual inconsistency when displaying the suggestions

[dicarobinho]

📜 Tickets

Jira ticket
Github issue

💡 Description

Reload data only after view transition is done/completed.

🎥 Demos

ScreenRecording_05-19-2026.16-15-26_1.mp4

Before	After

Demo

📝 Checklist

• I filled in the ticket numbers and a description of my work
• I updated the PR name to follow our PR naming guidelines
• I ensured unit tests pass and wrote tests for new code
• If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
• If adding telemetry, I read the data stewardship requirements and will request a data review
• If adding or modifying strings, I read the guidelines and will request a string review from l10n
• If needed, I updated documentation and added comments to complex code

[dicarobinho]

This bug is happening because viewModel.isBottomSearchBar does not have the correct value, when searchAppendImage is getting called, while screen rotation is happening.

Another fix can be: instead of reloading tableview data, we can refresh/configure only visible cells.

        guard let indexPaths = tableView.indexPathsForVisibleRows else { return }

        for indexPath in indexPaths {
            guard let oneLineCell = tableView.cellForRow(at: indexPath) as? OneLineTableViewCell else {
                continue
            }

            if let suggestion = viewModel.suggestions?[safe: indexPath.row] {
                let viewModel = oneLineCellModelForSearch(
                    with: suggestion,
                    shouldShowAccessoryView: indexPath.row > 0
                )
                oneLineCell.configure(viewModel: viewModel)
            }
        }

Demo with the fix from above:

ScreenRecording_05-19-2026.16-21-49_1.mp4

[mobiletest-ci-bot]

	Messages
📖	Project coverage: 42.21%

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

✅ Existing file code coverage

No modified file had significant enough changes for the coverage gate to run.

Client.app: Coverage: 40.62

File	Coverage
SearchViewController.swift	5.13%	⚠️

Generated by 🚫 Danger Swift against 2e53826

[yoanarios]

LGTM, tested and is working as expected