Add FXIOS-15840 [Ad Blocker] Add ad blocker badge to menu#33889
Add FXIOS-15840 [Ad Blocker] Add ad blocker badge to menu#33889issammani wants to merge 12 commits into
Conversation
Foxbolts
left a comment
There was a problem hiding this comment.
Some a11y tweaks and a question about ad blocker settings presentation from the menu. Otherwise looks good 👍
| label.numberOfLines = 0 | ||
| label.lineBreakMode = .byWordWrapping | ||
| label.adjustsFontForContentSizeCategory = true | ||
| label.accessibilityTraits = .button |
There was a problem hiding this comment.
I think we should make the entire view the a11y element here instead of the label, that way during voiceover the whole view is focused.
Would remove label.accessibilityTraits = .button and add label.isAccessibilityElement = false
then add this to the init:
isAccessibilityElement = true
accessibilityTraits = .buttonand accessibilityLabel = text in configure()
| } | ||
|
|
||
| func presentAdBlockerSettings() { | ||
| let browsingSettings = BrowsingSettingsViewController(profile: profile, windowUUID: windowUUID) |
There was a problem hiding this comment.
a parent coordinator is never set for BrowsingSettingsViewController, so the settings that open nested screens like Autoplay don't do anything here. Is this intended?
| bottom: UX.siteProtectionsContentVerticalPadding, | ||
| right: UX.siteProtectionsContentHorizontalPadding) | ||
| stack.distribution = .fill | ||
| private lazy var badgesStack: UIStackView = .build { stack in |
|
This pull request has conflicts when rebasing. Could you fix it @issammani? 🙏 |
|
This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions! |

📜 Tickets
Jira ticket
Github issue
💡 Description
This PR:
Uploading Simulator Screen Recording - iPhone 17 Pro - 2026-05-19 at 15.48.52.mov…
🎥 Demos
Demo
📝 Checklist