Skip to content

Bugfix FXIOS-15837 Search bar not visible after rotation#33913

Merged
rilury merged 1 commit into
mainfrom
riordan/FXIOS-15837_Searchbar-not-visible-after-rotation
May 20, 2026
Merged

Bugfix FXIOS-15837 Search bar not visible after rotation#33913
rilury merged 1 commit into
mainfrom
riordan/FXIOS-15837_Searchbar-not-visible-after-rotation

Conversation

@rilury

@rilury rilury commented May 20, 2026

Copy link
Copy Markdown
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR fixes the bug related to the search bar that will disappear while editing after rotating from landscape to portrait mode.

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@mobiletest-ci-bot

Copy link
Copy Markdown
Messages
📖 Project coverage: 42.18%

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

🦊 BrowserViewController Check

We’re tracking the size of BrowserViewController.swift to keep it healthy.

  • ✨ Change in file size: +9 lines

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

✅ Existing file code coverage

No modified file had significant enough changes for the coverage gate to run.

Client.app: Coverage: 40.64

File Coverage
BrowserViewController.swift 36.16% ⚠️

Generated by 🚫 Danger Swift against 4f8d861

@rilury rilury requested a review from thatswinnie May 20, 2026 09:34
@rilury rilury marked this pull request as ready for review May 20, 2026 09:35
@rilury rilury requested a review from a team as a code owner May 20, 2026 09:35
@rilury rilury requested a review from yoanarios May 20, 2026 14:17
@yoanarios

Copy link
Copy Markdown
Contributor

I've tested the fix but I found a side effect, after rotating back to portrait the address bar and search engines are showing correctly but the search results are not visible anymore instead the homepage is showing

ScreenRecording_05-20-2026.10-39-49_1.MP4

@yoanarios

Copy link
Copy Markdown
Contributor

I've tested the fix but I found a side effect, after rotating back to portrait the address bar and search engines are showing correctly but the search results are not visible anymore instead the homepage is showing
ScreenRecording_05-20-2026.10-39-49_1.MP4

The bug is reproducible in main so it's not related to the fix, we should create a new ticket and work separately

@rilury

rilury commented May 20, 2026

Copy link
Copy Markdown
Collaborator Author

@Mergifyio backport release/v151.1

@rilury rilury merged commit 318f61c into main May 20, 2026
9 checks passed
@rilury rilury deleted the riordan/FXIOS-15837_Searchbar-not-visible-after-rotation branch May 20, 2026 15:08
@github-actions

Copy link
Copy Markdown
Contributor

🚀 PR merged to main, targeting version: 151.2

@mergify

mergify Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

backport release/v151.1

✅ Backports have been created

Details

Cherry-pick of 318f61c has failed:

On branch mergify/bp/release/v151.1/pr-33913
Your branch is up to date with 'origin/release/v151.1'.

You are currently cherry-picking commit 318f61cd7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants