Bugfix FXIOS-15125 ⁃ The inline PDF viewer is not working properly#33915
Open
dicarobinho wants to merge 1 commit into
Open
Bugfix FXIOS-15125 ⁃ The inline PDF viewer is not working properly#33915dicarobinho wants to merge 1 commit into
dicarobinho wants to merge 1 commit into
Conversation
🧹 Tidy commitJust 1 file(s) touched. Thanks for keeping it clean and review-friendly! ✅ New file code coverageNo new file detected so code coverage gate wasn't ran. ✅ Existing file code coverageNo modified file had significant enough changes for the coverage gate to run. Client.app: Coverage: 40.73
Generated by 🚫 Danger Swift against c2b8fa8 |
| if response.mimeType == MIMEType.PDF, | ||
| let request, | ||
| let url = request.url, | ||
| url.pathExtension.lowercased() == "pdf" { |
Collaborator
There was a problem hiding this comment.
i'm not sure this is a correct fix, cause i think there are link that don't ends with pdf. with this some websites will fail downloading the pdf.
Collaborator
Author
There was a problem hiding this comment.
That may be true... I will check if there is a better way to make a difference between these types.
Collaborator
There was a problem hiding this comment.
perfect thanks Alex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Handling an edge case when mimeType is PDF but URL have HTML content
🎥 Demos
ScreenRecording_05-20-2026.14-52-58_1.mp4
Demo
📝 Checklist