Bugfix FXIOS-15857 [Newsfeed Categories] Fix search results disappearance after rotation#33931
Merged
Merged
Conversation
💪 Quality guardian2 tests files modified. You're a champion of test coverage! 🚀 🧹 Tidy commitJust 3 file(s) touched. Thanks for keeping it clean and review-friendly! 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 🦊 BrowserViewController CheckWe’re tracking the size of
✅ New file code coverageNo new file detected so code coverage gate wasn't ran. ✅ Existing file code coverageNo modified file had significant enough changes for the coverage gate to run. Client.app: Coverage: 40.97
Generated by 🚫 Danger Swift against 7c93569 |
yoanarios
approved these changes
May 21, 2026
yoanarios
left a comment
yoanarios
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀, tested and the bug is fixed
Contributor
|
🚀 PR merged to |
Alex-Bangu
pushed a commit
that referenced
this pull request
May 25, 2026
…ance after rotation (#33931)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
📝 Technical Notes:
updateContentContainerTopConstraint()was bringing thecontentContainerto the front when the homepage pinned header was enabled, and during rotation, that method runs again while search is active, so the homepage could visually coverSearchViewController. Search was not actually dismissed, it was still in the hierarchy, but hidden behind the content container, so we now resurface the activeSearchViewControllerview after pinned homepage z-order updatesSearchViewController(that you see in the after video) was a pre-existing issueupdateContentContainerTopConstraint()handles both layout constraints and view z-ordering and because that method runs from broad lifecycle paths like rotation/layout updates, it can unintentionally change z-ordering unless every active overlay is accounted for 😞🎥 Demos
Before
Simulator.Screen.Recording.-.iPhone.17.-.2026-05-20.at.19.28.54.mov
After
Simulator.Screen.Recording.-.iPhone.17.-.2026-05-20.at.19.26.16.mov
📝 Checklist