Skip to content

Commit a915c72

Browse files
committed
Fixup status generation for NetmgrController
1 parent e0d4e5a commit a915c72

2 files changed

Lines changed: 16 additions & 9 deletions

File tree

src/platforms/linux/netmgrcontroller.cpp

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ void NetmgrController::initialize(const Device* device, const Keys* keys) {
6666
}
6767
m_uuid = uuid.toString(QUuid::WithoutBraces);
6868

69-
m_deviceIpv4Address = device->ipv4Address();
69+
m_deviceIpv4Address = QHostAddress(device->ipv4Address().split('/').first());
70+
m_deviceIpv6Address = QHostAddress(device->ipv6Address().split('/').first());
7071

7172
// Generic connection settings.
7273
m_config.insert("id", QCoreApplication::applicationName());
@@ -248,11 +249,16 @@ void NetmgrController::activate(const InterfaceConfig& config,
248249
m_ipv6config.insert("route-data", ipv6routes);
249250
m_wireguard.insert("peers", peers);
250251

252+
// Keep the server details for later.
253+
m_serverPublicKey = config.m_serverPublicKey;
254+
m_serverIpv4Gateway = QHostAddress(config.m_serverIpv4Gateway);
255+
m_serverIpv6Gateway = QHostAddress(config.m_serverIpv6Gateway);
256+
251257
// Update the DNS server.
252258
if ((config.m_dnsServer == config.m_serverIpv4Gateway) ||
253259
(config.m_dnsServer == config.m_serverIpv6Gateway)) {
254-
setDnsConfig(m_ipv4config, QHostAddress(config.m_serverIpv4Gateway));
255-
setDnsConfig(m_ipv6config, QHostAddress(config.m_serverIpv6Gateway));
260+
setDnsConfig(m_ipv4config, m_serverIpv4Gateway);
261+
setDnsConfig(m_ipv6config, m_serverIpv6Gateway);
256262
} else if (config.m_dnsServer.contains(':')) {
257263
setDnsConfig(m_ipv4config, QHostAddress());
258264
setDnsConfig(m_ipv6config, QHostAddress(config.m_dnsServer));
@@ -261,10 +267,6 @@ void NetmgrController::activate(const InterfaceConfig& config,
261267
setDnsConfig(m_ipv6config, QHostAddress());
262268
}
263269

264-
// Keep the server details for later.
265-
m_serverPublicKey = config.m_serverPublicKey;
266-
m_serverIpv4Gateway = config.m_serverIpv4Gateway;
267-
268270
// Update the connection settings.
269271
QList<QVariant> args;
270272
args << serializeConfig();
@@ -395,7 +397,9 @@ void NetmgrController::checkStatus() {
395397
st.m_connected = true;
396398
st.m_timestamp = guessUptime();
397399
st.m_ipv4Gateway = m_serverIpv4Gateway;
400+
st.m_ipv6Gateway = m_serverIpv6Gateway;
398401
st.m_ipv4Address = m_deviceIpv4Address;
402+
st.m_ipv6Address = m_deviceIpv6Address;
399403
st.m_rxBytes = readSysfsFile(rxPath);
400404
st.m_txBytes = readSysfsFile(txPath);
401405

src/platforms/linux/netmgrcontroller.h

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
#define NETWORKMANAGERCONTROLLER_H
77

88
#include <QDBusObjectPath>
9+
#include <QHostAddress>
910
#include <QObject>
1011
#include <QVariant>
1112
#include <QVersionNumber>
@@ -75,8 +76,10 @@ class NetmgrController final : public ControllerImpl {
7576
QVariantMap m_wireguard;
7677

7778
QString m_serverPublicKey;
78-
QString m_serverIpv4Gateway;
79-
QString m_deviceIpv4Address;
79+
QHostAddress m_serverIpv4Gateway;
80+
QHostAddress m_serverIpv6Gateway;
81+
QHostAddress m_deviceIpv4Address;
82+
QHostAddress m_deviceIpv6Address;
8083
QString m_uuid;
8184

8285
QVersionNumber m_version;

0 commit comments

Comments
 (0)