Draft
Conversation
Collaborator
|
This is awesome, I would love to be rid of the Qt5 compat module, but I don't think we can merge this until we drop support for our PPA builds as those are holding us back to Qt 6.2.4 (Jammy) and Qt 6.4.2 (Noble). |
Collaborator
@strseb with this, do you want a review now, or should we hold this for a bit? |
Collaborator
Author
|
I think Let's keep it in limbo for a bit until we have control over that. Marking this as Draft for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
My build with Qt 6.11 fails to create the QML window, due to an error in Qt5 GraphicEffects Compat module.
it might just be a blip with my build, but i thought thats a good opportunity to replace the old compat module with Qt6 QML Effects.
Note given i'm using RectangularShadow - so we now have MINIMUM reqiurement of Qt 6.9. If we want to avoid that, i probably could also use the multi-effect element, just like the others.