Skip to content

Remove Qt Compat Graphic effects#11153

Draft
strseb wants to merge 1 commit intomainfrom
basti/ptkzqsvvylmz
Draft

Remove Qt Compat Graphic effects#11153
strseb wants to merge 1 commit intomainfrom
basti/ptkzqsvvylmz

Conversation

@strseb
Copy link
Copy Markdown
Collaborator

@strseb strseb commented Mar 25, 2026

Description

My build with Qt 6.11 fails to create the QML window, due to an error in Qt5 GraphicEffects Compat module.
it might just be a blip with my build, but i thought thats a good opportunity to replace the old compat module with Qt6 QML Effects.

Note given i'm using RectangularShadow - so we now have MINIMUM reqiurement of Qt 6.9. If we want to avoid that, i probably could also use the multi-effect element, just like the others.

@strseb strseb requested a review from mcleinman March 25, 2026 11:49
@oskirby
Copy link
Copy Markdown
Collaborator

oskirby commented Mar 25, 2026

This is awesome, I would love to be rid of the Qt5 compat module, but I don't think we can merge this until we drop support for our PPA builds as those are holding us back to Qt 6.2.4 (Jammy) and Qt 6.4.2 (Noble).

@mcleinman
Copy link
Copy Markdown
Collaborator

This is awesome, I would love to be rid of the Qt5 compat module, but I don't think we can merge this until we drop support for our PPA builds as those are holding us back to Qt 6.2.4 (Jammy) and Qt 6.4.2 (Noble).

@strseb with this, do you want a review now, or should we hold this for a bit?

@strseb
Copy link
Copy Markdown
Collaborator Author

strseb commented Mar 30, 2026

I think Let's keep it in limbo for a bit until we have control over that. Marking this as Draft for now

@strseb strseb marked this pull request as draft March 30, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants