Skip to content

VPN-7540: add optional button to info card#11173

Merged
mcleinman merged 1 commit intomainfrom
vpn-7540-optional-button-on-info-card
Apr 7, 2026
Merged

VPN-7540: add optional button to info card#11173
mcleinman merged 1 commit intomainfrom
vpn-7540-optional-button-on-info-card

Conversation

@mcleinman
Copy link
Copy Markdown
Collaborator

@mcleinman mcleinman commented Apr 1, 2026

Description

For #11169. Let me know if you'd like any changes. The button is definitely visually prominent - for your use case this seems okay (we really want the user to click the button and do the action), but it may not be appropriate for all cases.

I also reworked the button a bit to move the height into the MZInformationCard (the card should worry about its height), and removed a long-time annoyance of a double divider line in a dev menu.

As you can see from the example, there are two new fields:

_buttonText: "Tap for alert"
_buttonAction: function() { MZErrorHandler.requestAlert(MZErrorHandler.GeoIpRestrictionAlert) }

Without _buttonText, the info cards look the same as they did before. I've confirmed there are no regressions on any usage of the MZInformationCard.

New version:
Screenshot 87

No regressions:
Screenshot 88

Reference

VPN-7540

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

Copy link
Copy Markdown
Collaborator

@strseb strseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is LOVELY! Thank you!!

@mcleinman mcleinman merged commit 8850b30 into main Apr 7, 2026
155 of 156 checks passed
@mcleinman mcleinman deleted the vpn-7540-optional-button-on-info-card branch April 7, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants