WIP: Implement wireguard tunnel in the network extension#11236
Draft
oskirby wants to merge 31 commits into
Draft
WIP: Implement wireguard tunnel in the network extension#11236oskirby wants to merge 31 commits into
oskirby wants to merge 31 commits into
Conversation
5 tasks
55ab4ca to
e0d4e5a
Compare
a915c72 to
60e76d3
Compare
60e76d3 to
038fe7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the next iteration of the split tunneling work, we merge the daemon and network-extension together. This allows some significant improvements in how the tunneling operates. Most notably:
RTF_IFSCOPEon its default route.Much of this work came from PR #10460 and was just updated to move it into the network extension.
Quirks and TODO items
Because the split tunneling provider only catches TCP and UDP packet flows. There might be some traffic that can sneak passed the VPN when its active now (ICMP is the obvious case here). This could be a some future research... possibly engaging with the macOS firewall to block any such traffic. Theoretically Apple might also have some secret sauce that can create traffic flows that skip the
NETransparentProxyProviderso we are kind of trusting Apple a lot more with this approach.DNS. There seems to be some contention when it comes to the DNS configuration when
NETransparentProxyProvideris used (see here). So as-of now, it doesn't seem like we have a good solution to setting the DNS config.No support for native multihop. This might be doable with some future work, but it complicates the API significantly. As a first cut, I decided to disable the feature for now.
Reference
Checklist