Reviewers comments

Author: isabelrios

changelog-analysis/Jenkinsfile.create-smart-test-runs

@@ -2,6 +2,7 @@ pipeline {
     agent any
 
     parameters {
+        string(name: 'RELEASE_TAG',  description: 'Current release tag (e.g., firefox-v145.0)')
         string(name: 'MILESTONE_ID', description: 'TestRail milestone ID')
     }
 
@@ -12,7 +13,7 @@ pipeline {
     environment {
         PATH          = "/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/homebrew/bin:${env.PATH}"
         GITHUB_TOKEN  = credentials('github-token')
-        SLACK_WEBHOOK = credentials('slack-mobile-alerts-tooling-webhook')
+        SLACK_WEBHOOK = credentials('slack-mobile-alerts-sandbox-webhook')
     }
 
     stages {
@@ -35,7 +36,11 @@ pipeline {
         stage('Install Dependencies') {
             steps {
                 dir('changelog-analysis') {
-                    sh 'pip3 install --no-cache-dir -r requirements.txt'
+                    sh '''
+                        set -e
+                        python3 -m venv .venv
+                        .venv/bin/pip install --no-cache-dir -r requirements.txt
+                    '''
                 }
             }
         }
@@ -45,14 +50,14 @@ pipeline {
                 dir('changelog-analysis') {
                     script {
                         def output = sh(
-                            script: 'python3 run_release_selection.py',
+                            script: ".venv/bin/python3 run_release_selection.py --head_tag ${params.RELEASE_TAG} --milestone_id ${params.MILESTONE_ID}",
                             returnStdout: true
                         ).trim()
 
                         echo output
 
-                        def headMatch = output =~ /Head tag from latest_tags\.json:\s+(\S+)/
-                        def baseMatch = output =~ /Base tag \(previous version\):\s+(\S+)/
+                        def headMatch = output =~ /Head tag:\s+(\S+)/
+                        def baseMatch = output =~ /Base tag:\s+(\S+)/
 
                         env.HEAD_TAG = headMatch ? headMatch[0][1] : 'unknown'
                         env.BASE_TAG = baseMatch ? baseMatch[0][1] : 'unknown'

changelog-analysis/get_change_log.py

@@ -131,16 +131,33 @@ def map_files_to_components(files: List[str], rules) -> Tuple[Set[str], List[str
 
 
 def get_changed_files(owner: str, repo: str, base: str, head: str) -> List[str]:
-    url = f"https://api.github.com/repos/{owner}/{repo}/compare/{base}...{head}"
-    response = requests.get(url, headers=_github_headers())
-    response.raise_for_status()
-
-    all_files = [f["filename"] for f in response.json().get("files", [])]
-    filtered = [f for f in all_files if not is_ignored_path(f)]
+    commit_shas = []
+    page = 1
+    while True:
+        response = requests.get(
+            f"https://api.github.com/repos/{owner}/{repo}/compare/{base}...{head}",
+            headers=_github_headers(),
+            params={"per_page": 100, "page": page},
+        )
+        response.raise_for_status()
+        commits = response.json().get("commits", [])
+        commit_shas.extend(c["sha"] for c in commits)
+        if len(commits) < 100:
+            break
+        page += 1
+
+    all_files: Set[str] = set()
+    for sha in commit_shas:
+        response = requests.get(
+            f"https://api.github.com/repos/{owner}/{repo}/commits/{sha}",
+            headers=_github_headers(),
+        )
+        response.raise_for_status()
+        all_files.update(f["filename"] for f in response.json().get("files", []))
 
+    filtered = [f for f in sorted(all_files) if not is_ignored_path(f)]
     print(f"Total changed files (raw): {len(all_files)}")
     print(f"After filtering ignored paths: {len(filtered)}")
-
     return filtered
 
 

changelog-analysis/run_release_selection.py

@@ -22,20 +22,24 @@ def main():
         description="Smart release test selection based on changelog diff.",
         epilog="Tags are read from testrail/latest_tags.json when not provided explicitly.",
     )
-    parser.add_argument("base_tag", nargs="?", help="Previous release tag")
-    parser.add_argument("head_tag", nargs="?", help="Current release tag")
+    parser.add_argument("--base_tag", help="Previous release tag")
+    parser.add_argument("--head_tag", help="Current release tag")
     parser.add_argument("--milestone_id", type=int, help="TestRail milestone ID")
     args = parser.parse_args()
 
-    if args.base_tag and args.head_tag:
+    if args.head_tag and not args.base_tag:
+        head_tag = args.head_tag
+        base_tag = get_base_tag(head_tag, IOS_OWNER, IOS_REPO)
+    elif args.base_tag and args.head_tag:
         base_tag, head_tag = args.base_tag, args.head_tag
     elif args.base_tag or args.head_tag:
-        parser.error("Provide both base_tag and head_tag, or neither.")
+        parser.error("Provide both --base_tag and --head_tag, or only --head_tag.")
     else:
         head_tag = read_head_tag()
-        print(f"Head tag from latest_tags.json: {head_tag}")
         base_tag = get_base_tag(head_tag, IOS_OWNER, IOS_REPO)
-        print(f"Base tag (previous version):    {base_tag}")
+
+    print(f"Head tag: {head_tag}")
+    print(f"Base tag: {base_tag}")
 
     print(f"\nComparing {base_tag} → {head_tag}")
 

testrail/Jenkinsfile.create-milestone

@@ -42,7 +42,11 @@ pipeline {
         stage('Install Dependencies') {
             steps {
                 dir('testrail') {
-                    sh 'pip3 install --no-cache-dir -r requirements.txt'
+                    sh '''
+                        set -e
+                        python3 -m venv .venv
+                        .venv/bin/pip install --no-cache-dir -r requirements.txt
+                    '''
                 }
             }
         }
@@ -75,7 +79,7 @@ EOF
             steps {
                 dir('testrail') {
                     script {
-                        def result = sh(script: 'python3 testrail_main_ios.py', returnStatus: true)
+                        def result = sh(script: '.venv/bin/python3 testrail_main_ios.py', returnStatus: true)
                         if (result == 0) {
                             echo "✅ Milestone created successfully"
                             env.MILESTONE_CREATED = 'true'