Skip to content

Commit 190edd0

Browse files
committed
create grepable pin with context for spanner
1 parent 4c5090c commit 190edd0

3 files changed

Lines changed: 10 additions & 0 deletions

File tree

.github/workflows/main-workflow.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -836,6 +836,7 @@ jobs:
836836

837837
services:
838838
spanner-emulator:
839+
# SPANNER_EMULATOR_VER (unit tests) — keep in sync with docker/docker-compose.spanner.yaml
839840
image: gcr.io/cloud-spanner-emulator/emulator:1.4.0
840841
ports:
841842
- 9010:9010

docker/docker-compose.spanner.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ services:
77
# I believe come from the SQL parser, but am not sure. I am
88
# unable to produce these errors locally, and am using the cited
99
# version.
10+
# SPANNER_EMULATOR_VER (e2e/integration tests) — keep in sync with .github/workflows/main-workflow.yml
11+
# Pinned to 1.5.13 (not 1.4.0) to avoid sporadic "INTERNAL: ZETASQL_RET_CHECK failure" errors.
1012
image: gcr.io/cloud-spanner-emulator/emulator:1.5.13
1113
ports:
1214
- "9010:9010"

docs/src/introduction.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -355,6 +355,13 @@ Note, that unlike MySQL, there is no automatic migrations facility. Currently, t
355355

356356
Google supports an in-memory Spanner emulator, which can run on your local machine for development purposes. You can install the emulator via the gcloud CLI or Docker by following the instructions [here](https://cloud.google.com/spanner/docs/emulator#installing_and_running_the_emulator). Once the emulator is running, you'll need to create a new instance and a new database.
357357

358+
**Updating the emulator version:** The emulator version is pinned in two places, each marked with `SPANNER_EMULATOR_VER`:
359+
360+
- `docker/docker-compose.spanner.yaml` — used for e2e/integration tests (currently pinned to a specific version to avoid ZetaSQL query engine errors; see the comment there before bumping)
361+
- `.github/workflows/main-workflow.yml` — used for CI unit tests
362+
363+
When upgrading, update both and verify that neither the ZetaSQL issue nor any new regressions appear in CI.
364+
358365
##### Quick Setup Using prepare-spanner.sh
359366

360367
The easiest way to set up a Spanner emulator database is to use the `prepare-spanner.sh` script:

0 commit comments

Comments
 (0)