Skip to content

docs: add one-shot docker compose yaml to how-to#2025

Merged
chenba merged 1 commit into
masterfrom
docs/one-shot-docker-compose
Jan 28, 2026
Merged

docs: add one-shot docker compose yaml to how-to#2025
chenba merged 1 commit into
masterfrom
docs/one-shot-docker-compose

Conversation

@chenba
Copy link
Copy Markdown
Collaborator

@chenba chenba commented Jan 27, 2026

Add a one-shot docker file to start the db with docker compose also. Follow-up to STOR-118 / #1428 / PR #2019.

@chenba chenba requested review from pjenvey and taddes January 27, 2026 18:50
taddes
taddes previously approved these changes Jan 27, 2026
Copy link
Copy Markdown
Collaborator

@taddes taddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just one suggestion

```yaml
services:
syncserver:
image: ghcr.io/mozilla-services/syncstorage-rs/syncstorage-rs-postgres:11659d98f9
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it up to you, but perhaps just a note to clarify that the hash value after syncstorage-rs-postgres: corresponds to a particular build in the aforementioned link (https://github.com/mozilla-services/syncstorage-rs/pkgs/container/syncstorage-rs%2Fsyncstorage-rs-postgres) and for someone to select that accordingly.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was relying on the note at https://github.com/mozilla-services/syncstorage-rs/blob/master/docs/src/how-to/how-to-run-with-docker.md?plain=1#L15-L17 but yeah that is not exactly explicit. I can definitely mention the tag hash but there's no good, succinct advice on how to pick a tag; they are just merges on the main branch after all.

I was planning on updating the tags in the doc once we tagged the next release.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably consider a separate issue to add additional docker tags to help with such setups, like a typical "latest", and "<major>", "<major>.<minor>" available on many of the popular dockers.

For now I'm fine with the hash, or how about syncstorage-rs-postgres:${SYNCSERVER_VERSION:-11659d98f9}

@chenba chenba merged commit 646e516 into master Jan 28, 2026
32 checks passed
@chenba chenba deleted the docs/one-shot-docker-compose branch January 28, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants