chore: Update GAR Image Tagging to MozCloud Spec#2029
Conversation
|
Thought I'd tag you on this one @grahamalama in case I was missing something with the mozilla-it maintained action. I just created a job to gen the timestamp and then pass it in the It does work successfully, but given the way the workflow goes, it adds two |
taddes
force-pushed
the
chore/update-gar-img-tagging-STOR-451
branch
2 times, most recently
from
044cc96 to
74e50fa
Compare
| - master | ||
| tags: | ||
| - '**' | ||
| - "**" |
There was a problem hiding this comment.
Doesn't this make it less consistent with the rest of file/PR? I see 'master' and 'refs/tags/' for example.
There was a problem hiding this comment.
For some reason my auto-formatter in VSCode keeps demanding that, I'll see if I can disable the prefs for the double quotes.
There was a problem hiding this comment.
Ah, no worries. Just thought the change was a bit odd; makes more sense now knowing it was an auto-formatter.
grahamalama
left a comment
grahamalama
left a comment
There was a problem hiding this comment.
It does work successfully, but given the way the workflow goes, it adds two -, see here. Any way to avoid that or is that fine?
Oof, that was certainly an oversight on my part when writing that standard 😅. Probably should have kept the double hyphen consistent between both versions. For now, the double hyphen is okay as long as you match that pattern accordingly in your tenant.
If I understand your intent with this PR, are you going to set image_regex: <sha 10>--<timestamp> for each Argo application and then toggle auto sync on or off for different environments? If so, you'll want to make sure to update all of the image_regex values here?
| id-token: write | ||
| packages: write | ||
| uses: mozilla-it/deploy-actions/.github/workflows/build-and-push.yml@1b87069d293273436a84dff04954a8950d3ff9ca # v6.1.0 | ||
| uses: mozilla-it/deploy-actions/.github/workflows/build-and-push.yml@v6.2.2 |
There was a problem hiding this comment.
I would still recommend pinning at the full SHAand adding the semver tag at the end. Dependabot knows how to update the comments along with the SHA. Though we're a "trusted creator", it's still something Zizmor will flag (if you're using that).
There was a problem hiding this comment.
Thanks so much for chiming in @grahamalama ! I'll go ahead and make those changes too and get a PR for you folks in global-platform-admin for those image_regex values. Appreciate you pointing me right to them.
taddes
force-pushed
the
chore/update-gar-img-tagging-STOR-451
branch
from
1bc89e1 to
94e7f83
Compare
|
Sry @pjenvey @chenba , rebase and changes from @grahamalama made review approval stale. Need approval again. |
pjenvey
left a comment
pjenvey
left a comment
There was a problem hiding this comment.
want to log an issue for the image_regex change?
eh it could just be part of this STOR-451 though |
Yes good call. I've got it in STOR-434 already as the general update, but will note @grahamalama 's comment there too 👍 |
4 participants
Description
Per MozCloud’s spec on Container Images and Continuous Deployment, we want to align our image tagging in GAR and GHCR to match the org-wide standard to include the release date.
Tags must consist of:
A short Git commit SHA (10 characters)
A UTC timestamp in the format YYYYMMDDTHHMMSS
<short-sha>-<YYYYMMDDTHHMMSS>Testing
Output from workflow (will verify in branch)
Issue(s)
Closes STOR-451.