feat: adapt PoolState to usage of deadpool everywhere#2128
Merged
Conversation
chenba
previously approved these changes
Mar 16, 2026
just killing it for deadpool::Status since it provides a public constructor and kill the long unused syncstorage-spanner bb8 based manager Closes STOR-368
pjenvey
force-pushed
the
refactor/pool-status-STOR-368
branch
from
5a56059 to
70e1284
Compare
chenba
approved these changes
Mar 17, 2026
taddes
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
just killing it for deadpool::Status since it provides a public constructor (I also doubt we'd ever use anything but deadpool in the future)
and kill the long unused syncstorage-spanner bb8 based manager
Issue(s)
Closes STOR-368