chore: build and push "directly" instead of using mozilla-it/deploy-actions#2149
chore: build and push "directly" instead of using mozilla-it/deploy-actions#2149
Conversation
4cd77c1 to
edd6cd3
Compare
pjenvey
left a comment
There was a problem hiding this comment.
I'll just note the obvious that we could go even further, breaking apart our usage of the build action (I noticed remote-settings basically rolls their own https://github.com/mozilla/remote-settings/blob/main/.github/workflows/publish-ent.yaml) or even tweaking the mozcloud actions/workflow to better suite these needs
But this is definitely a good, easy improvement
| create_credentials_file: false | ||
|
|
||
| - name: Configure GAR | ||
| run: gcloud auth configure-docker us-docker.pkg.dev --quiet |
There was a problem hiding this comment.
I notice the mozcloud docker-push action does a docker/login-action here instead: https://github.com/mozilla-it/deploy-actions/blob/b9d76236c1d1dd89daab4ea15651cbe76574267a/docker-push/action.yml#L39 I'm not sure it matters?
There was a problem hiding this comment.
Yeah, this would be good to update since I was planning on breaking those out in the broader workflow updates.
Thanks, I'll take a look. |
794b672 to
3b1f267
Compare
c997a6f to
180c2e6
Compare
180c2e6 to
1d5aa64
Compare
|
The two GAR pushes are on different steps; it appears docker/login-action won't allow two auth sessions to us-docker.pkg.dev simultaneously. Not a big deal since the later step can rely on cache. |
1d5aa64 to
d8c775f
Compare
| with: | ||
| persist-credentials: false | ||
|
|
||
| - uses: ./.github/actions/build-and-push |
There was a problem hiding this comment.
This evolved into more of a setup-build-and-push action, I think it could use a renaming to something along those lines?
d8c775f to
9963461
Compare
9963461 to
8108278
Compare
|
Preview environment has been deployed. Preview URL: https://pr2149-tokenserver.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
8108278 to
5eabb6d
Compare
We relied on mozilla-it/deploy-actions's build-and-push to push a couple of Docker images to another GAR in GCP. That duplicate the image builds. With this patch we'll define the build-and-push actions ourselves.
Additionally, we'll push a 'latest' tag to the non-enterprise image registries on a git tag push.
Closes STOR-499, STOR-509