Depend on PostgreSQL token server if building PostgreSQL sync server#2194
Open
ntninja wants to merge 2 commits intomozilla-services:masterfrom
Open
Depend on PostgreSQL token server if building PostgreSQL sync server#2194ntninja wants to merge 2 commits intomozilla-services:masterfrom
ntninja wants to merge 2 commits intomozilla-services:masterfrom
Conversation
Member
|
This looks reasonable but this breaks some CI assumptions within our Dockerfile, where the default build arg of I think simplifying that to always specifying |
13 tasks
ntninja
force-pushed
the
fix-tokenserver-postgresql
branch
from
3e35e6d to
2a298b3
Compare
…ckend when testing As of the previous commit, the MySQL TokenServer backend is only enabled if SyncServer is also using MySQL or Spanner, otherwise it needs to be enabled explicitely.
ntninja
force-pushed
the
fix-tokenserver-postgresql
branch
from
2a298b3 to
9c92cf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Building the PostgreSQL syncserver should also build the PostgreSQL token server, currently one gets a mixed build which is kinda weird and pretty annoying for packaging.
Testing
How should reviewers test?
Should build the PostgreSQL Sync- and Token-Server.
Not, the PostgreSQL Sync-Server with the MySQL Token-Server.