Draft
Conversation
pjenvey
force-pushed
the
wip/testdb-trait
branch
from
0dc6d4f to
9c7c51d
Compare
Collaborator
|
I'm in favor of cancelling the issue. If the more experienced Rust dev doesn't like the complexity introduced in the changes, then, as the less experienced Rust dev, I prefer not having it in the code base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Draft a
TestDbtrait which seemed like the best alternative in the STOR-380 options for these test methods, but I'm not in love with the bit of the complication it adds for whatimpl<T: stuff> Db for Tis -- I'm leaning towards cancelling this issue entirely (or probably doing the adding some comments option)Issue(s)
Issue STOR-380