Open
Conversation
taddes
force-pushed
the
feat/pinning-spanner-image-STOR-391
branch
from
e4b0207 to
d6bdeb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This resolves the concern by centralizing the Spanner emulator version into a single, clearly defined constant that is reused across all contexts (Docker image pulls, emulator usage in tests, and docker-compose).
The version is now explicitly tagged in a grepable format
SPANNER_EMULATOR_VER, making it easy to locate. This removes the risk of version drift, however the zetasql issue still presents an issue we might want to look atIssue(s)
Closes STOR-391.