Skip to content

feat: allow quota enforcement for all db backends#2381

Merged
chenba merged 3 commits into
masterfrom
feat/quotas-for-all-stor-598
Jun 23, 2026
Merged

feat: allow quota enforcement for all db backends#2381
chenba merged 3 commits into
masterfrom
feat/quotas-for-all-stor-598

Conversation

@chenba

@chenba chenba commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

This commit:

  • implements storage quotas for MySQL and Postgres
  • fixes a bug in Spanner's batch quota calculation

Closes STOR-598

@chenba chenba force-pushed the feat/quotas-for-all-stor-598 branch 3 times, most recently from ea3422c to 0461ade Compare June 10, 2026 18:33
@chenba chenba marked this pull request as ready for review June 10, 2026 18:52
@chenba chenba requested a review from pjenvey June 10, 2026 18:52
@chenba chenba marked this pull request as draft June 11, 2026 21:47
@chenba chenba force-pushed the feat/quotas-for-all-stor-598 branch from 0461ade to 0951f51 Compare June 12, 2026 22:22
@chenba chenba marked this pull request as ready for review June 12, 2026 22:43
This commit:
 - implements storage quotas for MySQL and Postgres
 - fixes a bug in Spanner's batch quota calculation
@chenba chenba force-pushed the feat/quotas-for-all-stor-598 branch from 0951f51 to 65dbafe Compare June 15, 2026 14:11

@pjenvey pjenvey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Barry, lgtm.

I remembered the history behind spanner's quota being per collection (and double checked w/ JR). We were more concerned about quota at the collection level due to the original issues encountered with spanner at the time in 2020 -- a small number of users with very large collections weren't able to cleanly separate across a Spanner split

@chenba chenba merged commit d7b8911 into master Jun 23, 2026
24 checks passed
@chenba chenba deleted the feat/quotas-for-all-stor-598 branch June 23, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants