Commit 3cbf57e
authored
fix(ads-client): change MozAdsTelemetry from with_foreign to callback_interface (#7443)
MozAdsTelemetry is always implemented by the foreign side (JS/Kotlin/Swift)
and is only ever passed from foreign code to Rust — never the other way around.
callback_interface is the correct semantic for this pattern and enables the
geckojs uniffi-bindgen-gecko-js pipeline to generate FireAndForget vtable
handlers, avoiding a deadlock where Rust calls telemetry methods synchronously
from within a callSync on the JS main thread.1 parent 8490290 commit 3cbf57e
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
166 | | - | |
| 165 | + | |
| 166 | + | |
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
0 commit comments