Bug 2049263 - Add LoginsBridgedEngine to expose logins sync to Desktop#7439
Open
jo wants to merge 2 commits into
Open
Bug 2049263 - Add LoginsBridgedEngine to expose logins sync to Desktop#7439jo wants to merge 2 commits into
jo wants to merge 2 commits into
Conversation
5 tasks
…p via UniFFI Co-Authored-By: Johannes Salas Schmidt <joschmidt@mozilla.com> Co-Authored-By: Krist Baliev <kbaliev@mozilla.com>
The Rust logins sync engine now skips the chrome://FirefoxAccounts FxA-login when collecting outgoing records, matching the exclusion the JS PasswordEngine does on Desktop. Without this, the FxA session credentials would be uploaded once Desktop syncs logins through the bridged engine.
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=2049263
Pull Request checklist
[ci full]to the PR title.