refactor(ads-client): telemetry callback interface#7443
Merged
Almaju merged 1 commit intoJun 22, 2026
Conversation
…_interface MozAdsTelemetry is always implemented by the foreign side (JS/Kotlin/Swift) and is only ever passed from foreign code to Rust — never the other way around. callback_interface is the correct semantic for this pattern and enables the geckojs uniffi-bindgen-gecko-js pipeline to generate FireAndForget vtable handlers, avoiding a deadlock where Rust calls telemetry methods synchronously from within a callSync on the JS main thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revives #7407, rebased on the latest
main.MozAdsTelemetryis always implemented by the foreign side (JS/Kotlin/Swift) and is only ever passed from foreign code to Rust — never the other way around.callback_interfaceis the correct semantic for this pattern and enables the geckojsuniffi-bindgen-gecko-jspipeline to generate FireAndForget vtable handlers, avoiding a deadlock where Rust calls telemetry methods synchronously from within acallSyncon the JS main thread.The builder's
telemetry()argument changes fromArc<dyn MozAdsTelemetry>toBox<dyn MozAdsTelemetry>accordingly.Pull Request checklist
cargo test -p ads-client: 88 passed)