Skip to content

Add engines #16906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maureenlholland wants to merge 2 commits into from
+15 −23
Closed

Add engines #16906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de74d07
Update node to v24 and set npm version in node engines
maureenlholland Dec 1, 2025
ec39fd9
Clean out dependabot-added peer fields
maureenlholland Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/a11y_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- uses: actions/checkout@v5
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 24
- name: Install dependencies
run: cd tests/playwright && npm ci && npm run install-deps
- name: Run accessibility tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
- uses: actions/checkout@v5
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 24
- name: Install dependencies
run: cd tests/playwright && npm ci && npm run install-deps
- name: Run Playwright tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v5
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 24
cache: npm
- name: "Install JS dependencies"
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ RUN pip install --require-hashes --no-cache-dir -r requirements/prod.txt
########
# assets builder and dev server
#
FROM node:20.14.0-slim AS assets
FROM node:24-slim AS assets

@janbrasna janbrasna Dec 2, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've written up some past decisions in #16910 for consideration.

(My personal take would be… try major only for now, and constrain more explicitly if any woes appear later — being expected more on developers' ARM machines, not the Linux build pipelines.)


ENV PATH=/app/node_modules/.bin:$PATH
WORKDIR /app
Expand Down
26 changes: 7 additions & 19 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
"version": "0.1.0",
"description": "Making mozilla.org awesome, one pebble at a time",
"private": true,
"engines": {
"node": "^24.0.0",

@janbrasna janbrasna Dec 1, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bedrock currently runs on Node 20:

bedrock/Dockerfile

Line 25 in 4b47277

FROM node:20.14.0-slim AS assets

"npm": "^11.6.4"
},
"dependencies": {
"@babel/core": "^7.28.5",
"@babel/preset-env": "^7.28.5",
Expand Down