Skip to content

Update from Node 20 to Node 24#17168

Merged
maureenlholland merged 5 commits into
mainfrom
update-node-version
May 27, 2026
Merged

Update from Node 20 to Node 24#17168
maureenlholland merged 5 commits into
mainfrom
update-node-version

Conversation

@maureenlholland

@maureenlholland maureenlholland commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Also adds Sass-related deps to dependabot ignore settings. They can be removed from this setting at the same time Sass is unpinned.

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label.

One-line summary

Significant changes and points to review

Issue / Bugzilla link

#16910
Twinned with mozmeao/springfield#1180

Testing

Successful integration test run: https://github.com/mozilla/bedrock/actions/runs/25670980573

Successful integration test (May 26, 2026) with no Node 20 warnings: https://github.com/mozilla/bedrock/actions/runs/26446688757

Also adds Sass-related deps to dependabot ignore settings. They can
be removed from this setting at the same time Sass is unpinned.
@maureenlholland
maureenlholland marked this pull request as ready for review May 11, 2026 13:40
@maureenlholland maureenlholland added the Needs Review Awaiting code review label May 11, 2026

@janriokrause janriokrause left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ Looks good to me. Integration tests ran successfully, but I didn't test anything manually.

@stevejalim stevejalim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're happy, I'm happy @maureenlholland

Question (blocking): how come package-lock.json didn't change when the headline node version has? Do the the JS deps need recompiling locally using node 24, changing the package-lock.json, I'm assuming, as part of this upgrade?

@maureenlholland

Copy link
Copy Markdown
Collaborator Author

@stevejalim I don't think so. I ran npm install locally with node v24.15.0 and saw no package-lock changes.

But I don't think the v4 setup node is doing what we want. Will move to v5 and check integration tests again.

@maureenlholland

Copy link
Copy Markdown
Collaborator Author

Integration test run for v6: https://github.com/mozilla/bedrock/actions/runs/26104915009
confirmed running Node 24

@maureenlholland

Copy link
Copy Markdown
Collaborator Author

It is probably worth updating these other actions in this PR too:
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected:

  • actions/upload-artifact@v4
  • slackapi/slack-github-action@v1.25.0

@maureenlholland maureenlholland added WIP Pull request is still work in progress and removed Needs Review Awaiting code review labels May 20, 2026
@maureenlholland

Copy link
Copy Markdown
Collaborator Author

https://github.com/mozilla/bedrock/actions/runs/26170334565
good news: the node 20 warnings are gone
bad news: slackapi is broken

need to fix slack (probably missing breaking changes required with major update)

@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.34%. Comparing base (e8e2529) to head (058de56).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17168      +/-   ##
==========================================
+ Coverage   82.31%   82.34%   +0.03%     
==========================================
  Files         181      181              
  Lines        9692     9709      +17     
==========================================
+ Hits         7978     7995      +17     
  Misses       1714     1714              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maureenlholland maureenlholland removed the WIP Pull request is still work in progress label May 26, 2026
@maureenlholland
maureenlholland merged commit d6841f2 into main May 27, 2026
@maureenlholland
maureenlholland deleted the update-node-version branch May 27, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants