Update from Node 20 to Node 24#17168
Conversation
Also adds Sass-related deps to dependabot ignore settings. They can be removed from this setting at the same time Sass is unpinned.
janriokrause
left a comment
There was a problem hiding this comment.
r+ Looks good to me. Integration tests ran successfully, but I didn't test anything manually.
There was a problem hiding this comment.
If you're happy, I'm happy @maureenlholland
Question (blocking): how come package-lock.json didn't change when the headline node version has? Do the the JS deps need recompiling locally using node 24, changing the package-lock.json, I'm assuming, as part of this upgrade?
|
@stevejalim I don't think so. I ran But I don't think the v4 setup node is doing what we want. Will move to v5 and check integration tests again. |
|
Integration test run for v6: https://github.com/mozilla/bedrock/actions/runs/26104915009 |
|
It is probably worth updating these other actions in this PR too:
|
|
https://github.com/mozilla/bedrock/actions/runs/26170334565 need to fix slack (probably missing breaking changes required with major update) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17168 +/- ##
==========================================
+ Coverage 82.31% 82.34% +0.03%
==========================================
Files 181 181
Lines 9692 9709 +17
==========================================
+ Hits 7978 7995 +17
Misses 1714 1714 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5461ce4 to
10245b5
Compare
Also adds Sass-related deps to dependabot ignore settings. They can be removed from this setting at the same time Sass is unpinned.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.One-line summary
Significant changes and points to review
Issue / Bugzilla link
#16910
Twinned with mozmeao/springfield#1180
Testing
Successful integration test run: https://github.com/mozilla/bedrock/actions/runs/25670980573Successful integration test (May 26, 2026) with no Node 20 warnings: https://github.com/mozilla/bedrock/actions/runs/26446688757