Skip to content

WT-1273 remove Selenium tests#17234

Merged
wen-2018 merged 5 commits into
mainfrom
drop-selenium
Jun 23, 2026
Merged

WT-1273 remove Selenium tests#17234
wen-2018 merged 5 commits into
mainfrom
drop-selenium

Conversation

@wen-2018

@wen-2018 wen-2018 commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label.

One-line summary

This PR removes Selenium tests from the codebase.

Significant changes and points to review

All Slelenium tests, docs, CI should be removed.

Issue / Bugzilla link

https://mozilla-hub.atlassian.net/browse/WT-1273

Testing

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy Selenium/PyPOM-based functional test framework from Bedrock (page objects, Selenium-specific fixtures, and CI/grid wiring) and simplifies the integration-test workflows to run only the remaining HTTP-based pytest suites (plus Playwright separately).

Note: This review was performed following the repository’s custom Copilot instructions (including checking AGENTS.md guidance and verifying repository-wide references via search).

Changes:

  • Deleted Selenium/PyPOM page objects and the one remaining Selenium navigation test.
  • Removed Selenium-related pytest fixtures/markers and pruned Selenium/PyPOM dependencies from dev requirements.
  • Simplified integration test scripts and GitHub Actions workflows by removing Selenium Grid / SauceLabs configuration.

Reviewed changes

Copilot reviewed 17 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/pages/regions/send_to_device.py Deletes Selenium region object.
tests/pages/regions/modal.py Deletes Selenium modal region objects.
tests/pages/regions/menu_list.py Deletes Selenium region object.
tests/pages/regions/download_button.py Deletes Selenium region object.
tests/pages/regions/init.py Removes package file (Selenium pages).
tests/pages/home.py Deletes Selenium home page object.
tests/pages/base.py Deletes Selenium/PyPOM base page + navigation region.
tests/pages/init.py Removes PyPOM compatibility shim and monkeypatches.
tests/functional/test_navigation.py Removes Selenium-based navigation functional test.
tests/functional/conftest.py Removes Selenium/driver capability fixtures; keeps HTTP parametrization helpers.
setup.cfg Removes Selenium-era pytest config and trims marker declarations.
requirements/dev.txt Removes Selenium/PyPOM/pytest-selenium stack from the locked dev requirements.
requirements/dev.in Removes Selenium/PyPOM/pytest-selenium inputs; adds explicit pytest-base-url.
bin/run-integration-tests.sh Deletes older integration test runner script (superseded by bin/integration_tests/...).
bin/integration_tests/run_integration_tests.sh Simplifies runner by removing SauceLabs/Remote/Selenium CLI flags.
bin/integration_tests/functional_tests.sh Removes Selenium Grid bring-up and Selenium-related env wiring.
bin/integration_tests/docker_compose_for_integration_tests.yml Removes Selenium Grid docker compose definition.
bin/integration_tests/cleanup_after_functional_tests.sh Removes Selenium Grid teardown logic.
.github/workflows/integration_tests.yml Removes SauceLabs/IE matrix; runs only headless-marked pytest + Playwright job.
.github/workflows/download_tests.yml Drops unused Selenium env vars for download tests workflow.
.github/workflows/cdn_tests.yml Drops unused Selenium env vars for CDN tests workflow.

Comment thread setup.cfg
@wen-2018
wen-2018 marked this pull request as ready for review June 17, 2026 15:08
@wen-2018
wen-2018 requested review from a team as code owners June 17, 2026 15:08
@wen-2018 wen-2018 added the Needs Review Awaiting code review label Jun 17, 2026
@maureenlholland maureenlholland self-assigned this Jun 18, 2026

@maureenlholland maureenlholland left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc => let's hold off on merge until we have a successful integration test run

The vendor-local folder looks like an unrelated change. Otherwise, all looks good to me.

Comment thread requirements/dev.in Outdated
Comment thread vendor-local/src/legal-docs Outdated
@maureenlholland

Copy link
Copy Markdown
Collaborator

@wen-2018

Copy link
Copy Markdown
Collaborator Author

The integration tests have passed: https://github.com/mozilla/bedrock/actions/runs/27839980565/job/82396622227. The playwright tests failures seem to be related to the VPN env discussed here: https://mozilla.slack.com/archives/C0960JM31PE/p1781721519443169

@maureenlholland maureenlholland left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ good to go! (just waiting for current deploy to finish before merge)

Comment thread requirements/dev.in
pytest-cov==7.1.0
pytest-datadir==1.8.0
pytest-django==4.12.0
pytest-html==4.2.0 # Provides the --html option used to generate the integration test report

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for the comment!

@maureenlholland

Copy link
Copy Markdown
Collaborator

@wen-2018 sorry I missed the merge window here 🤦‍♀️ this is good to merge once the requirements conflicts are fixed

@wen-2018
wen-2018 merged commit 4026815 into main Jun 23, 2026
6 checks passed
@wen-2018
wen-2018 deleted the drop-selenium branch June 23, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants