Remove combined-manifesto switch, and take old Leadership page out of circulation#17253
Merged
Conversation
299a1bc to
d51ec26
Compare
d073407 to
dcad212
Compare
stephaniehobson
commented
Jun 26, 2026
dcad212 to
a73175f
Compare
a73175f to
9189acf
Compare
combined-manifesto switch, content is now permanent
c17604d to
9f2f8bc
Compare
9f2f8bc to
0e7f7d5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17253 +/- ##
==========================================
- Coverage 82.84% 82.80% -0.05%
==========================================
Files 178 178
Lines 9409 9409
==========================================
- Hits 7795 7791 -4
- Misses 1614 1618 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
combined-manifesto switch, content is now permanentcombined-manifesto switch, and take old Leadership page out of circulation
78e92fe to
0e7f7d5
Compare
stevejalim
reviewed
Jul 6, 2026
|
|
||
| class AboutUsPage(AbstractBedrockCMSPage): | ||
| subpage_types = [ | ||
| LeadershipPage, |
Contributor
There was a problem hiding this comment.
I don't think this will stop is deleting the existing LeadershipPage if it still exists. Worst-case we can temporarily put it back in before we drop the actual model
stevejalim
approved these changes
Jul 6, 2026
stevejalim
left a comment
Contributor
There was a problem hiding this comment.
LGTM - one small thought
r+wc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
Clean up from WT-1320
Significant changes and points to review
combined-manifestoswitch, content is now permanentNote: The work to remove stub-attribution from non-Firefox pages on bedrock was bundled with this accidentally.
Issue / Bugzilla link
WT-1389
Testing
http://localhost:8000/en-US/about/
http://localhost:8000/en-US/about/manifesto/
http://localhost:8000/en-US/foundation/moco/