Simplify Context and DeviceCollection implementation and move them from core to api - #117
Open
marcin-serwin wants to merge 4 commits into
Open
Simplify Context and DeviceCollection implementation and move them from core to api#117marcin-serwin wants to merge 4 commits into
core to api#117marcin-serwin wants to merge 4 commits into
Conversation
marcin-serwin
marked this pull request as draft
June 3, 2025 20:23
marcin-serwin
force-pushed
the
push-tymqnssmwmzx
branch
2 times, most recently
from
June 25, 2025 16:34
a76f69e to
abec01d
Compare
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
marcin-serwin
force-pushed
the
push-tymqnssmwmzx
branch
2 times, most recently
from
July 30, 2025 17:55
a7f9c33 to
1b23210
Compare
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
marcin-serwin
force-pushed
the
push-tymqnssmwmzx
branch
from
July 30, 2025 18:00
1b23210 to
cc098b2
Compare
marcin-serwin
marked this pull request as ready for review
July 30, 2025 18:06
marcin-serwin
commented
Jul 30, 2025
marcin-serwin
changed the title
core to apicore to api
Contributor
Author
|
@kinetiknz Could you review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #115 and #116.
The move is motivated by cleaner responsibility separation between
coreandapi:coreshould contain structures necessary for communication between backends and the lib, whileapiprovides safe wrappers around rawsysc api calls.