fix(nimbus): omit monitoring data when cloning experiments (#15248)

Because

* Cloned experiments carried over monitoring data from the parent
* Monitoring data is specific to the parent experiment's lifecycle and
  is not relevant to the new clone

This commit

* Nulls out `monitoring_data` during the clone step
* Adds a data migration to clear `monitoring_data` on non-Live/Complete
  experiments
* Updates clone test to set `monitoring_data` on parent and assert it is
  `None` on the child
* Updates migration test to cover the new data migration

Fixes #15247

Author: jaredlockhart

experimenter/experimenter/experiments/migrations/0327_clear_monitoring_data_non_live_complete.py

@@ -0,0 +1,18 @@
+from django.db import migrations
+
+
+def clear_monitoring_data(apps, schema_editor):
+    NimbusExperiment = apps.get_model("experiments", "NimbusExperiment")
+    NimbusExperiment.objects.exclude(status__in=["Live", "Complete"]).update(
+        monitoring_data=None
+    )
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("experiments", "0326_alter_nimbusexperiment_next_steps_and_more"),
+    ]
+
+    operations = [
+        migrations.RunPython(clear_monitoring_data),
+    ]

experimenter/experimenter/experiments/models.py

@@ -2079,6 +2079,7 @@ def clone(self, name, user, rollout_branch_slug=None, changed_on=None):
         cloned.published_dto = None
         cloned.published_date = None
         cloned.results_data = None
+        cloned.monitoring_data = None
         cloned.takeaways_summary = None
         cloned.next_steps = None
         cloned.project_impact = None

experimenter/experimenter/experiments/tests/test_migrations.py

@@ -1,104 +1,53 @@
 from django_test_migrations.contrib.unittest_case import MigratorTestCase
 
 
-class TestRemoveVpnApplicationsMigration(MigratorTestCase):
+class TestClearMonitoringDataMigration(MigratorTestCase):
     migrate_from = (
         "experiments",
-        "0318_alter_nimbusexperiment_application_and_more",
+        "0326_alter_nimbusexperiment_next_steps_and_more",
     )
     migrate_to = (
         "experiments",
-        "0319_delete_vpn_features",
+        "0327_clear_monitoring_data_non_live_complete",
     )
 
     def prepare(self):
         User = self.old_state.apps.get_model("auth", "User")
-        NimbusFeatureConfig = self.old_state.apps.get_model(
-            "experiments", "NimbusFeatureConfig"
-        )
         NimbusExperiment = self.old_state.apps.get_model(
             "experiments", "NimbusExperiment"
         )
-        NimbusIsolationGroup = self.old_state.apps.get_model(
-            "experiments", "NimbusIsolationGroup"
-        )
 
         owner, _ = User.objects.get_or_create(
             username="test@example.com",
             defaults={"email": "test@example.com"},
         )
 
-        NimbusFeatureConfig.objects.get_or_create(
-            slug="no-feature-vpn-web",
-            defaults={
-                "name": "No Feature VPN Web",
-                "application": "vpn-web",
-            },
-        )
-
-        NimbusFeatureConfig.objects.get_or_create(
-            slug="no-feature-fenix",
-            defaults={
-                "name": "No Feature Fenix",
-                "application": "fenix",
-            },
-        )
-
-        NimbusExperiment.objects.get_or_create(
-            slug="test-vpn-web",
-            defaults={
-                "name": "Test VPN Web",
-                "application": "vpn-web",
-                "owner": owner,
-            },
-        )
+        self.monitoring_data = {"total_enrollments": 100, "total_unenrollments": 5}
 
-        NimbusExperiment.objects.get_or_create(
-            slug="test-fenix",
-            defaults={
-                "name": "Test Fenix",
-                "application": "fenix",
-                "owner": owner,
-            },
-        )
-
-        NimbusIsolationGroup.objects.get_or_create(
-            application="vpn-web",
-            name="test-group",
-            instance=1,
-        )
-
-        NimbusIsolationGroup.objects.get_or_create(
-            application="fenix",
-            name="test-group",
-            instance=1,
-        )
+        for status in ("Draft", "Preview", "Live", "Complete"):
+            NimbusExperiment.objects.create(
+                slug=f"test-{status.lower()}",
+                name=f"Test {status}",
+                application="firefox-desktop",
+                owner=owner,
+                status=status,
+                monitoring_data=self.monitoring_data,
+            )
 
     def test_migration(self):
-        NimbusFeatureConfig = self.new_state.apps.get_model(
-            "experiments", "NimbusFeatureConfig"
-        )
         NimbusExperiment = self.new_state.apps.get_model(
             "experiments", "NimbusExperiment"
         )
-        NimbusIsolationGroup = self.new_state.apps.get_model(
-            "experiments", "NimbusIsolationGroup"
-        )
 
-        self.assertFalse(
-            NimbusFeatureConfig.objects.filter(slug="no-feature-vpn-web").exists()
+        self.assertIsNone(NimbusExperiment.objects.get(slug="test-draft").monitoring_data)
+        self.assertIsNone(
+            NimbusExperiment.objects.get(slug="test-preview").monitoring_data
         )
-
-        self.assertTrue(
-            NimbusFeatureConfig.objects.filter(slug="no-feature-fenix").exists()
+        self.assertEqual(
+            NimbusExperiment.objects.get(slug="test-live").monitoring_data,
+            self.monitoring_data,
         )
-
-        self.assertFalse(NimbusExperiment.objects.filter(application="vpn-web").exists())
-
-        self.assertTrue(NimbusExperiment.objects.filter(application="fenix").exists())
-
-        self.assertFalse(
-            NimbusIsolationGroup.objects.filter(application="vpn-web").exists()
+        self.assertEqual(
+            NimbusExperiment.objects.get(slug="test-complete").monitoring_data,
+            self.monitoring_data,
         )
-
-        self.assertTrue(NimbusIsolationGroup.objects.filter(application="fenix").exists())

experimenter/experimenter/experiments/tests/test_models.py

@@ -4093,6 +4093,7 @@ def test_clone_created_experiment(self):
             application=NimbusExperiment.Application.DESKTOP,
             conclusion_recommendations=["RERUN", "STOP"],
             takeaways_summary="takeaway",
+            monitoring_data={"total_enrollments": 500, "total_unenrollments": 10},
         )
         NimbusExperimentBranchThroughRequired.objects.create(
             parent_experiment=parent,
@@ -4216,6 +4217,7 @@ def _clone_experiment_and_assert_common_expectations(
         self.assertEqual(child.published_dto, None)
         self.assertEqual(child.published_date, None)
         self.assertEqual(child.results_data, None)
+        self.assertEqual(child.monitoring_data, None)
         self.assertEqual(child.takeaways_gain_amount, None)
         self.assertEqual(child.takeaways_metric_gain, False)
         self.assertEqual(child.takeaways_qbr_learning, False)