Conversation
| if kpi["slug"] == NimbusConstants.RETENTION_3_DAYS: | ||
| kpi["displayed_window"] = "Day 4" | ||
| if kpi["slug"] == NimbusConstants.RETENTION: | ||
| kpi["displayed_window"] = "Week 2" |
There was a problem hiding this comment.
Are these always accurate based on the data available? Like what happens on Day 3? Do we show "Day 4" for RETENTION_3_DAYS, or do we just show nothing? And I'm fairly sure Week 2 for Retention could be wrong in some cases because we haven't done #12647 yet, so it could be Week 1 (the old Results page always said Week 2 Retention so maybe we don't need to block on this).
I just want to make sure we aren't going to be potentially showing the wrong thing for early or wonky (missing days/weeks) results.
There was a problem hiding this comment.
fair points. the changes im making in #15050 will make it so 3day retention will remain unavailable until day 4 data is available so it will show nothing on Day <4 or if the metric has no data (this goes for all metrics). in that case i think the most logical thing to do would be to complete #15050 and #12647 before this
|
There was some recent confusion on what the Overview section of the metric details modal is showing -- can/should we tack something on to this PR to update that too? Or file a new ticket? |
|
i think we can just include that change in this pr and broaden the scope/title to covering general improvements to analysis window representation |

Because
This commit
Fixes #14850