Skip to content

feat(nimbus): add analaysis window indicator inside metric name cards #15239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moibra05 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

feat(nimbus): add analaysis window indicator inside metric name cards #15239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions experimenter/experimenter/jetstream/results_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,11 @@ def append_kpi_metric_fields(
kpi["slug"], kpi["group"], analysis_basis, segment, reference_branch
)

if kpi["slug"] == NimbusConstants.RETENTION_3_DAYS:
kpi["displayed_window"] = "Day 4"
if kpi["slug"] == NimbusConstants.RETENTION:
kpi["displayed_window"] = "Week 2"
Comment on lines +390 to +393
Copy link
Copy Markdown
Contributor

@mikewilli mikewilli Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these always accurate based on the data available? Like what happens on Day 3? Do we show "Day 4" for RETENTION_3_DAYS, or do we just show nothing? And I'm fairly sure Week 2 for Retention could be wrong in some cases because we haven't done #12647 yet, so it could be Week 1 (the old Results page always said Week 2 Retention so maybe we don't need to block on this).

I just want to make sure we aren't going to be potentially showing the wrong thing for early or wonky (missing days/weeks) results.

Copy link
Copy Markdown
Contributor Author

@moibra05 moibra05 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair points. the changes im making in #15050 will make it so 3day retention will remain unavailable until day 4 data is available so it will show nothing on Day <4 or if the metric has no data (this goes for all metrics). in that case i think the most logical thing to do would be to complete #15050 and #12647 before this


def get_remaining_metrics_metadata(
self, exclude_slugs=None, analysis_basis=None, segment=None, reference_branch=None
):
Expand Down
7 changes: 7 additions & 0 deletions experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/results-inner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,13 @@ <h4 class="mb-0">{{ area }}</h4>
{% if not metric.has_data %}cursor: default;{% endif %}">
{% if metric.has_data %}
<i class="fa-solid fa-arrow-up-right-from-square text-secondary fa-sm position-absolute top-0 end-0 p-3 px-2"></i>
<small class="position-absolute bottom-0 end-0 p-2 fw-medium">
{% if metric.displayed_window %}
{{ metric.displayed_window|upper }}
{% else %}
{{ displayed_window|upper }}
{% endif %}
</small>
{% endif %}
<p class=" metric-text mb-0">{{ metric.friendly_name }}</p>
</button>
Expand Down
Loading