feat(schemas): Add support for setPref in SDK schemas#15512
Merged
Conversation
freshstrangemusic
requested review from
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
mikewilli
approved these changes
May 4, 2026
mikewilli
left a comment
mikewilli
left a comment
Contributor
There was a problem hiding this comment.
Looks like there's an errant extra line, but LGTM
freshstrangemusic
force-pushed
the
freshstrangemusic/push-kykuptuyzokl
branch
3 times, most recently
from
7b3dcb1 to
4fe0550
Compare
Member
Author
|
This is blocked until we set up the NPM and PyPI deploy secrets |
Collaborator
|
@jaredlockhart to fix schema publishing |
freshstrangemusic
force-pushed
the
freshstrangemusic/push-kykuptuyzokl
branch
from
4fe0550 to
09210d2
Compare
Member
Author
|
I removed the version bump to unblock this PR |
freshstrangemusic
removed this pull request from the merge queue due to a manual request
Because: - as of 152, Firefox for Android supports gecko prefs this commit: - adds support for setPref annotations in SDK manifests. Fixes #15511
freshstrangemusic
force-pushed
the
freshstrangemusic/push-kykuptuyzokl
branch
from
09210d2 to
6081ea1
Compare
RJAK11
pushed a commit
that referenced
this pull request
Jun 11, 2026
Because: - as of 152, Firefox for Android supports gecko prefs this commit: - adds support for setPref annotations in SDK manifests. Fixes #15511
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
this commit:
Fixes #15511