fix(nimbus): poll logcat for fenix log-state row instead of fixed sleep#15631
Merged
Conversation
Because * The fenix enrollment integration test was intermittently failing on the beta channel job with "No log-state row found": the fixed 5s wait after `nimbus-cli log-state` races the SDK's async row print, which is slower on beta than release. This commit * Replaces the 5s post-log-state sleep with a 60s bounded poll on `adb logcat -d` that exits as soon as the expected experiment row appears. * Lengthens the failure message to surface the timeout. Fixes #15629
jaredlockhart
requested review from
freshstrangemusic,
mikewilli and
yashikakhurana
as code owners
yashikakhurana
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
beta channel job with "No log-state row found": the fixed 5s wait after
nimbus-cli log-stateraces the SDK's async row print, which is sloweron beta than release.
This commit
adb logcat -dthat exits as soon as the expected experiment rowappears.
Fixes #15629