From 77f51ed06b9c560b8e9f125ff2b5ecd4534112cd Mon Sep 17 00:00:00 2001 From: mimi Date: Fri, 15 May 2026 10:27:35 -0400 Subject: [PATCH 1/3] feat(nimbus): Adds Win10 only existing users --- experimenter/experimenter/targeting/constants.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/experimenter/experimenter/targeting/constants.py b/experimenter/experimenter/targeting/constants.py index 4945d889d..207040a73 100644 --- a/experimenter/experimenter/targeting/constants.py +++ b/experimenter/experimenter/targeting/constants.py @@ -2446,6 +2446,20 @@ def __post_init__(self): application_choice_names=(Application.DESKTOP.name,), ) +EXISTING_USER_ONLY_WIN10 = NimbusTargetingConfig( + name="Existing user on Windows 10 only", + slug="existing_user_win10", + description=( + "Users with profiles older than 28 days " + "who are on Windows 10" + ), + targeting=f"{PROFILE28DAYS} && {WIN10_NOT_WIN11.targeting}", + desktop_telemetry="", + sticky_required=True, + is_first_run_required=False, + application_choice_names=(Application.DESKTOP.name,), +) + NEW_USER_FIVE_BOOKMARKS = NimbusTargetingConfig( name="New user (5 bookmarks)", slug="new_user_5_bookmarks", From dc5000b998484aea2bd4574d5e30f4fa0d92d4f2 Mon Sep 17 00:00:00 2001 From: mimi Date: Fri, 15 May 2026 11:16:42 -0400 Subject: [PATCH 2/3] fix linting line break --- experimenter/experimenter/targeting/constants.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/experimenter/experimenter/targeting/constants.py b/experimenter/experimenter/targeting/constants.py index 207040a73..e4941c374 100644 --- a/experimenter/experimenter/targeting/constants.py +++ b/experimenter/experimenter/targeting/constants.py @@ -2449,10 +2449,7 @@ def __post_init__(self): EXISTING_USER_ONLY_WIN10 = NimbusTargetingConfig( name="Existing user on Windows 10 only", slug="existing_user_win10", - description=( - "Users with profiles older than 28 days " - "who are on Windows 10" - ), + description=("Users with profiles older than 28 days who are on Windows 10"), targeting=f"{PROFILE28DAYS} && {WIN10_NOT_WIN11.targeting}", desktop_telemetry="", sticky_required=True, From 00415d8a2eb7f609e48b7796142c1252934c2eca Mon Sep 17 00:00:00 2001 From: mimi Date: Fri, 15 May 2026 11:18:45 -0400 Subject: [PATCH 3/3] remove description parenthesis --- experimenter/experimenter/targeting/constants.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/experimenter/experimenter/targeting/constants.py b/experimenter/experimenter/targeting/constants.py index e4941c374..ff45b5030 100644 --- a/experimenter/experimenter/targeting/constants.py +++ b/experimenter/experimenter/targeting/constants.py @@ -2449,7 +2449,7 @@ def __post_init__(self): EXISTING_USER_ONLY_WIN10 = NimbusTargetingConfig( name="Existing user on Windows 10 only", slug="existing_user_win10", - description=("Users with profiles older than 28 days who are on Windows 10"), + description="Users with profiles older than 28 days who are on Windows 10", targeting=f"{PROFILE28DAYS} && {WIN10_NOT_WIN11.targeting}", desktop_telemetry="", sticky_required=True,