From 6041b39d930ef80b07f8e556cb5b1c5ec8932144 Mon Sep 17 00:00:00 2001 From: Sarah Chung Date: Fri, 15 May 2026 12:38:01 -0400 Subject: [PATCH 1/2] feat(nimbus): add advanced targeting for win10 existing users needing default --- experimenter/experimenter/targeting/constants.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/experimenter/experimenter/targeting/constants.py b/experimenter/experimenter/targeting/constants.py index 4945d889dd..4b380c0421 100644 --- a/experimenter/experimenter/targeting/constants.py +++ b/experimenter/experimenter/targeting/constants.py @@ -1165,6 +1165,19 @@ def __post_init__(self): application_choice_names=(Application.DESKTOP.name,), ) +WIN10_EXISTING_USERS_NEED_DEFAULT = NimbusTargetingConfig( + name="Windows 10 existing users needing default", + slug="win10_existing_users_need_default", + description=( + "Windows 10 users with profiles older than 28 days needing default" + ), + targeting=f"{PROFILE28DAYS} && {WIN10_NEED_DEFAULT.targeting}", + desktop_telemetry="", + sticky_required=False, + is_first_run_required=False, + application_choice_names=(Application.DESKTOP.name,), +) + GUIDANCE_NOTIFICATION_GIF_EXPERIMENT = NimbusTargetingConfig( name="Guidance notification GIF experiment", slug="guidance_notification_gif_experiment", From e6df2d67b8eafa5f0f75783ac1e4c3b2d0debd8b Mon Sep 17 00:00:00 2001 From: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com> Date: Fri, 15 May 2026 16:47:44 -0400 Subject: [PATCH 2/2] chore(nimbus): apply ruff format to WIN10_EXISTING_USERS_NEED_DEFAULT description Because * CI's ruff format --check was failing on the new targeting constant because the description string fit on one line. This commit * Collapses the multi-line description=(...) onto a single line so ruff format --check passes. --- experimenter/experimenter/targeting/constants.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/experimenter/experimenter/targeting/constants.py b/experimenter/experimenter/targeting/constants.py index 4b380c0421..a708fbf415 100644 --- a/experimenter/experimenter/targeting/constants.py +++ b/experimenter/experimenter/targeting/constants.py @@ -1168,9 +1168,7 @@ def __post_init__(self): WIN10_EXISTING_USERS_NEED_DEFAULT = NimbusTargetingConfig( name="Windows 10 existing users needing default", slug="win10_existing_users_need_default", - description=( - "Windows 10 users with profiles older than 28 days needing default" - ), + description=("Windows 10 users with profiles older than 28 days needing default"), targeting=f"{PROFILE28DAYS} && {WIN10_NEED_DEFAULT.targeting}", desktop_telemetry="", sticky_required=False,