feat(nimbus): fetch and store enrollment funnel data alongside monitoring alerts#15735
Merged
Conversation
added 2 commits
May 26, 2026 15:18
…ring alerts (EXP-6872) Extends fetch_monitoring_data task to also pull enrollment_funnel_v1_latest.json from GCS and merge per-experiment funnel rows into monitoring_data["enrollment_funnel"]. Funnel fetch failures are handled gracefully (warning log, defaults to empty list) so alert data continues to save even when funnel data is unavailable.
yashikakhurana
requested review from
freshstrangemusic,
jaredlockhart and
mikewilli
as code owners
yashikakhurana
changed the title
freshstrangemusic
approved these changes
May 27, 2026
| "enrollment_funnel": funnel_by_slug.get(exp_slug, []), | ||
| } | ||
|
|
||
| if experiment.monitoring_data != merged: |
Member
There was a problem hiding this comment.
you can call save with only_fields=("monitoring_data", "monitoring_data_updated_at") to limit the DB update
Co-authored-by: Beth Rennie <beth@brennie.ca>
Co-authored-by: Beth Rennie <beth@brennie.ca>
…y with get_monitoring_data (EXP-6872)
mikewilli
reviewed
May 27, 2026
| def get_enrollment_funnel_data(): | ||
| filename = "enrollment_funnel_v1_latest.json" | ||
| path = Path(ENROLLMENT_COUNTS_FOLDER, filename) | ||
| return load_data_from_gcs(str(path)) |
Contributor
There was a problem hiding this comment.
I got distracted by a meeting partway through reviewing this, so I'll just leave a quick comment for posterity: This is another spot where it'd be nice to have the data defined in the schemas package so we can validate it.
Contributor
Author
There was a problem hiding this comment.
💯 we should definitely do schema validation, I will add that in the ticket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
get_enrollment_funnel_data()tojetstream/client.pyto loadenrollment_funnel_v1_latest.jsonfrom GCSfetch_monitoring_data()to fetch funnel data and merge it intoNimbusExperiment.monitoring_dataunder theenrollment_funnelkey alongside existing alert dataFixes #15519